Fix CSigningManager::VerifyRecoveredSig #3546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codablock
approved these changes
Jun 23, 2020
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Jun 24, 2020
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Mar 12, 2022
Duddino
pushed a commit
to Duddino/PIVX
that referenced
this pull request
Jan 14, 2025
Duddino
pushed a commit
to Duddino/PIVX
that referenced
this pull request
Jan 14, 2025
Duddino
pushed a commit
to Duddino/PIVX
that referenced
this pull request
Jan 14, 2025
Fuzzbawls
added a commit
to PIVX-Project/PIVX
that referenced
this pull request
Feb 1, 2025
595a672 Fix thread names to fit into 15 symbols (dashpay#3897) (UdjinM6) 2f492d4 evo/llmq/spork: Fix various (potential) locking issues (dashpay#3829) (UdjinM6) 453a74f Fix two potential issues in the way pending islocks are processed (dashpay#3678) (UdjinM6) 902809c replace `inter-quorum` with `intra-quorum` (dashpay#3642) (PastaPastaPasta) 46e51db Fix CSigningManager::VerifyRecoveredSig (dashpay#3546) (UdjinM6) dd02dfd Use exponential backoff timeouts for recovery (dashpay#3535) (Alexander Block) Pull request description: Each commits backports a different PR, as mentioned in the commit name ACKs for top commit: 595a672 Liquid369: ACK 595a672 Fuzzbawls: utACK 595a672 Tree-SHA512: 4d66215d3b1944266802045f66d2bec1a9e4eb7c7e2bfb16fcaf16bafda7e47225b43129094081990a5a25a9b9f753e9071f30d357dbe51e592f3b824384a461
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop useless
llmqParamscalculation, just usellmqTypearg directly. This calculation is also broken because it always usesParams().GetConsensus().llmqTypeChainLocksinstead of passedllmqTypebut, thankfully, this doesn't cause any issues cause ChainLock quorums are the only ones this function is used for currently. For any other quorum type this function would fail when you'd expect it to succeed, so it's more of a bug than a typo and it makes sense to backport it to v0.16.x imo.Fixes #3545
Thanks to @sidhujag for reporting 👍