bug: should use txidCollateral to calculate confirmations #1188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
note: all Travis jobs failed because of mismatching (?) dependencies, build should not fail because of the code changes |
|
Yeah, it's may be related to the Travis changes they did a month ago - I guess we'll need to backport #1133 edit: It seems to be a download error though... |
|
Restarting the builds, seems to work now |
|
Turned out it was deprecated download paths, fixed with #1219 |
Author
|
rebased to make sure only win64 fails as in #1219 |
|
The failing Win64 may be related to bitcoin#7891 |
Author
|
rebased on top of #1220 , waiting for travis... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.