Repository navigation
fix(identity): resolve a key's private half by matching material, not by deriving it from purpose (#889) #946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 37 commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
efee42d
feat(model): add the legacy identity recovery plan and additive merge
lklimek 3bab9a9
feat(database): read one legacy identity row through the shared row d…
lklimek b677776
feat(identity): restore keys stranded in the previous version's saved…
lklimek c2e859f
feat(masternodes): offer the previous version's stranded keys on the …
lklimek c274558
feat(identities): offer stranded legacy keys on the Key Info screen
lklimek e484589
docs(identity): record the legacy-key recovery flow and close the mig…
lklimek 63991b7
fix(model): only offer legacy keys that still correspond to the identity
lklimek f405098
fix(identity): stop holding the storage guard across the password prompt
lklimek 7caf529
fix(ui): keep the restore offer and the record it wrote in step
lklimek fc125f4
docs(identity): record what the recovery flow actually shipped
lklimek 24d3081
fix(model): stop the legacy blob from vouching for its own voter key
lklimek 4c42e55
fix(identity): gate the recovery offer on legacy rows, not on data.db…
lklimek cdde7f1
fix(ui): re-read the key screen on arrival and attribute a finished r…
lklimek be5299b
test(identity): pin the mid-flight protection guard against regression
lklimek ad22a2c
fix(model): stop the legacy blob from vouching for its own operator key
lklimek bff08f7
fix(masternodes): drop the missing-voter message that can never be shown
lklimek 171c512
fix(ui): let the recovery section read as a whole when it can restore…
lklimek 1612fc7
docs(identity): stop promising a voting-key restore that cannot happen
lklimek 2ade1b8
fix(identity): give the identity keys list a way into each key
lklimek 8db5341
test(identity): pin the restore outcome and the key naming on the key…
lklimek b1e2f28
test(identity): report both restore outcomes on the keys list in the …
lklimek ef665b1
fix(identity): make the keys list and Key Info agree on where a key i…
lklimek a237497
fix(identity): return from a key to a current list, in the identity's…
lklimek cb5b0de
fix(identity): one attribution rule for both hosts of the recovery offer
lklimek f36b4ca
fix(identity): identify a key by its public half, and name it the sam…
lklimek aa1234f
fix(identity): find a key's private half where it is filed, not where…
lklimek 2dbc996
fix(identity): Key Info names a user's keys the way the keys list does
lklimek d39457b
fix(identity): a disabled key the device holds is still reported as held
lklimek 3228b2a
fix(identity): resolve a key's store on demand instead of threading i…
lklimek 91fbc73
fix(masternodes): a key opened from a node's page keeps the name the …
lklimek 66a80a8
refactor(identity): make the key map private so the resolver cannot b…
lklimek 5f82b74
docs(identity): record the key-placement resolution design and the fix
lklimek 4042c01
refactor(identity): one held-key resolution rule for every Manage key…
lklimek a028d7e
refactor(identity): make an upstream key field a build failure, not a…
lklimek c95f067
Merge fix/889-key-info-navigation into the key-placement resolver
lklimek c898a70
test(identity): pin that removing one key spares a different key shar…
lklimek 001b3d5
Merge fix/889-key-info-navigation: port the key-field exhaustiveness …
lklimek 0e41d5d
fix(masternodes): resolve the Add-protection CTA's held key like ever…
lklimek 1a944eb
Merge remote-tracking branch 'origin/v1.0-dev' into fix/889-key-info-…
lklimek f334875
fix(identity): reach Key Info's re-read, share the restore offer, nam…
lklimek 2c264bb
docs(user-stories): point IDN-008 at the key list that shipped
lklimek 17feeea
Merge remote-tracking branch 'origin/fix/889-key-info-navigation' int…
lklimek 22ee879
fix(identity): route legacy-recovery test fixtures through insert_at/has
lklimek 9c99fe6
Merge remote-tracking branch 'origin/v1.0-dev' into fix/889-key-targe…
lklimek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟠 MEDIUM · blocking — the changelog now argues with itself, inside a single section.
Lines 87-98 add "A saved voting key can now actually sign" to
## [Unreleased] → ### Fixed. Six lines further down, still in the same### Fixedsection, the pre-existing entry at 125-133 continues to advise:This PR is the in-progress key-placement resolution fix.
remove_held_private_keynow removes every placementcandidatesselects, andremoving_one_key_leaves_a_different_key_sharing_its_id_alonepins it.get_commiton5f82b74confirms CHANGELOG.md gained 13 lines and removed exactly zero — the new entry was appended, the obsolete one was never reconciled.So the release notes will simultaneously tell a masternode operator the bug is fixed and instruct them to hand-audit every key after every save and remove, and promise a future fix that shipped in the same release. Three mutually incompatible statements, one section. The PR checklist ticks "
CHANGELOG.mdupdated", which is true in the narrowest possible sense.Fix: delete the "One known limitation …" paragraph (125-133), or reduce it to the residual that genuinely survives. Per your own
design.md§8 that residual is the orphaned vault secret on delete — not the wrong-key delete, which this PR actually closed. Whatever you keep, the sentence "This will be closed by the in-progress key-placement resolution fix." must not survive in a section that announces that fix.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed still present at HEAD
001b3d5c.CHANGELOG.md's### Fixedsection still carries both entries: the new "A saved voting key can now actually sign" bullet, and — a few lines later, inside the "An identity's keys are reachable again" bullet — the stale "known limitation ... This will be closed by the in-progress key-placement resolution fix" paragraph, which now self-referentially describes this same PR as still pending. Not reconciled.