ci: raise claudius-review timeout from 40 to 60 minutes by lklimek · Pull Request #912 · dashpay/dash-evo-tool

lklimek · 2026-07-20T14:18:32Z

Summary

Run 29744073162 (PR feat(migration): auto-refresh DAPI nodes during pre-1.0 migration #908, first run after lklimek/claudius-review-action's run_in_background fix landed) took 30m37s wall-clock against the 40-minute cap — under 10 minutes of headroom.
A larger PR would trip the timeout and lose the entire review after real work was already done (specialists dispatched, partially or fully collected, nothing written).
Companion fix: fix: TaskOutput-timeout guard, actor-permission preflight, report deps lklimek/claudius-review-action#7 (fix/ci-run-followups) hardens the same workflow's TaskOutput-blocking behavior, adds a write-access preflight, and fixes a missing report-rendering dependency.

Test plan

Next claudius-review run on a real PR completes within the new 60-minute window without needing it (no behavior change expected for typical-sized PRs, just headroom)

🤖 Generated with Claude Code

Summary by CodeRabbit

Chores
- Extended the automated code review time limit to allow longer-running reviews to complete.

Run 29744073162 (PR #908, first run after the run_in_background fix landed in lklimek/claudius-review-action) took 30m37s wall-clock, leaving under 10 minutes of headroom against the 40-minute cap. A larger PR would trip the timeout and lose the whole review after real work was already done.

coderabbitai · 2026-07-20T14:19:16Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 4cd43f78-e79a-46ad-a0e3-b939cd52cc8f

📥 Commits

Reviewing files that changed from the base of the PR and between 71f86d2 and 057b4ce.

📒 Files selected for processing (1)

.github/workflows/claude-code-review.yml

📝 Walkthrough

Walkthrough

The Claude review workflow’s review job timeout is increased from 40 to 60 minutes.

Changes

Review workflow configuration

Layer / File(s)	Summary
Extend review job timeout `.github/workflows/claude-code-review.yml`	The `review` job’s `timeout-minutes` setting changes from 40 to 60.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: claudius-maginificent

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Linked Issues check	⚠️ Warning	PR `#7` only raises the workflow timeout; it doesn't add the TaskOutput guard, permission preflight, dependency install, or label-warning hardening.	Implement the hardening items from `#7`, especially the TaskOutput re-block guard, actor-permission preflight, report-rendering dependencies, and warning on label-removal failures.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly states the main change: increasing the claudius-review CI timeout.
Out of Scope Changes check	✅ Passed	The only change is the intended workflow timeout increase; no unrelated edits are present.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/claudius-review-timeout

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 Checkov (3.3.8)

.github/workflows/claude-code-review.yml

Traceback (most recent call last):
File "/usr/local/bin/checkov", line 2, in
from checkov.main import Checkov
ModuleNotFoundError: No module named 'checkov'

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

thepastaclaw · 2026-07-20T14:21:07Z

✅ Final review complete — no blockers (commit 057b4ce)

thepastaclaw

Final validation — Codex + Sonnet

This PR raises the claudius-review CI job's timeout-minutes from 40 to 60 in .github/workflows/claude-code-review.yml, a single-line change confirmed against the exact diff. Both Codex and Sonnet reviewer evidence found no issues, and independent verification confirms the change is correct and low-risk.

Source: reviewers gpt-5.6-sol (general) and claude-sonnet-5 (general); final verifier claude-sonnet-5.

Review provenance

Codex reviewers: gpt-5.6-sol — general (failed), gpt-5.6-sol — general (completed)
Verifier: claude-sonnet-5 — final-verifier
Sonnet reviewers: claude-sonnet-5 — general (failed), claude-sonnet-5 — general (failed), claude-sonnet-5 — general (failed), claude-sonnet-5 — general (failed), claude-sonnet-5 — general (completed)

Brings in: shutdown fix (dashpay#905), duplicate-DPNS-name error message (dashpay#915), startup banner clearing (dashpay#916), nav pointer cursor + tooltips and wallet-less masternode indication (dashpay#917), onboarding disconnected- banner suppression (dashpay#907), masternode dialog/nav/passphrase fixes (dashpay#913), DAPI auto-refresh during pre-1.0 migration (dashpay#908), "Add Receiving Address" wiring + its test hardening (dashpay#914, dashpay#920), and a CI timeout bump (dashpay#912). dashpay#906 (shielded re-enable) was already pulled in individually last session, so its squashed commit merged as a no-op. Conflicts (6 files) were rebrand-naming overlaps (dash_evo_tool:: vs orchardpay:: imports) plus one real merge in left_panel.rs, where OrchardPay's green-icon tint had to combine with upstream's new nav tooltip. Also fixed 5 files upstream's auto-merged (non-conflicting) additions left un-rebranded: a stray DASH_EVO_DATA_DIR_LOCK/env-var name in a new app.rs test, and dash_evo_tool:: references in three kittest test files. Added tooltip strings for OrchardPay's own nav entries (OrchardPay, DashPay) so the new every_nav_entry_has_a_tooltip test covers them — upstream's version only knows its own nav items. Fixed the new nav_label_hover_shows_pointer_cursor kittest test: OrchardPay's nav rail carries two more always-visible entries than upstream's, pushing "Settings" below the scrollable list's default-size visible viewport; scroll it into view first, matching what a real user would do. Verified: cargo check (both feature modes), cargo clippy --all-features --all-targets -- -D warnings, cargo fmt --all, cargo test --all-features --workspace (2066 lib + 257 kittest + doc tests, 0 failed), all clean. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

thepastaclaw approved these changes Jul 20, 2026

View reviewed changes

lklimek merged commit 04b8212 into v1.0-dev Jul 20, 2026
1 check passed

lklimek deleted the fix/claudius-review-timeout branch July 20, 2026 16:09

Navigation Menu

Uh oh!

ci: raise claudius-review timeout from 40 to 60 minutes - #912

ci: raise claudius-review timeout from 40 to 60 minutes#912
lklimek merged 1 commit into
v1.0-devfrom
fix/claudius-review-timeout

lklimek commented Jul 20, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jul 20, 2026 •

edited

Loading

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

thepastaclaw commented Jul 20, 2026 •

edited

Loading

Uh oh!

thepastaclaw left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

lklimek commented Jul 20, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jul 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

thepastaclaw commented Jul 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thepastaclaw left a comment

Choose a reason for hiding this comment

Final validation — Codex + Sonnet

Review provenance

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

lklimek commented Jul 20, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jul 20, 2026 •

edited

Loading

thepastaclaw commented Jul 20, 2026 •

edited

Loading