feat(migration): import legacy v0.9.3 identities and their keys

docs/ai-design/2026-05-28-migration-tool/notes.md

@@ -203,19 +203,27 @@ idempotency is confirmed.
 
 ### `identity` (DET source file: `src/database/identities.rs`)
 
-- **Source:** `identity` in `data.db`
-- **Destination:** `identities.entry_blob` (typed BLOB column) in `platform-wallet-storage`
-- **Mapping:** Deserialize DET's stored identity representation → serialize as
-  bincode-encoded `QualifiedIdentity` with a leading version byte prepended
-- **Per-network split:** Yes
-- **Gotchas:** Upstream schema uses a leading version byte in `entry_blob` for
-  forward/backward compatibility — this byte must be present and set correctly, or upstream
-  deserialization will silently produce garbage. Confirm the byte format with the
-  platform-wallet-storage author before implementing. This is the highest-risk table in the
-  migration.
+> **SUPERSEDED (2026-07-13).** Design and task breakdown now live in
+> `docs/ai-design/2026-07-13-legacy-identity-migration/design.md`. The entry below is kept
+> for context; two of its claims are wrong. The destination is **not** upstream's
+> `identities.entry_blob` — commit `b14bf32c` moved it to DET's own per-network k/v
+> (`det:identity:v1` under `DetScope::Identity`, roster at `det:identity_index:v1`). And the
+> version byte needs no agreement with the platform-wallet-storage author: `DetKv::put`
+> prepends `kv::SCHEMA_VERSION` automatically, so an importer that goes through
+> `AppContext::insert_local_qualified_identity` gets it for free.
+
+- **Source:** `identity` in `data.db` (`is_local = 1 AND data IS NOT NULL`)
+- **Destination:** `StoredQualifiedIdentity` in DET's per-network k/v — see the design doc
+- **Mapping:** `QualifiedIdentity::from_bytes(row.data)` → restore `status` from its column →
+  `AppContext::insert_local_qualified_identity(&qi, &wallet_link)`. The `data` BLOB carries
+  **all identity key material**; there is no second key table in v0.9.3.
+- **Per-network split:** Yes — two-value filter (`mainnet` / legacy `dash`)
+- **Gotchas:** The real risk is cross-version bincode compatibility of the `data` BLOB, not a
+  version byte. Every DET-side and dpp-side struct in the blob was verified unchanged between
+  v0.9.3 and HEAD; only the `bincode` rc.3 → 2.0.1 wire format is unproven, and a golden-blob
+  test closes it. Still the highest-risk table in the migration.
 - **Status:** DONE for new-install path — see commit `b14bf32c` (identities + tokens →
-  per-network k/v). Migration tool still needs to import legacy rows with the version-byte
-  contract correct.
+  per-network k/v). Migration tool still needs to import legacy rows.
 
 ---
 

src/app.rs

@@ -139,6 +139,7 @@ pub fn migration_running_text(step: MigrationStep) -> &'static str {
         MigrationStep::Shielded => "Verifying shielded balance.",
         MigrationStep::WalletSeeds => "Moving your wallets into the new vault.",
         MigrationStep::WalletMeta => "Updating wallet names.",
+        MigrationStep::Identities => "Restoring your identities and their keys.",
         MigrationStep::Finalize => "Finishing storage update.",
     }
 }
@@ -156,6 +157,20 @@ pub fn migration_unreadable_votes_text(count: u32) -> String {
     )
 }
 
+/// User-facing banner copy for a migration that finished the wallet drain but
+/// could not decode `count` identities. Their keys are therefore not loaded, so
+/// the sentence names the action that restores them. Kept separate from the
+/// scheduled-votes copy because the remedy is different — load an identity, not
+/// re-schedule a vote. The previous version's data is never deleted, so the
+/// re-import is always possible. Exposed for kittest coverage.
+pub fn migration_unreadable_identities_text(count: u32) -> String {
+    format!(
+        "Some identities from the previous version could not be read and were not carried over \
+         ({count} in total). Your previous data is untouched. Load these identities again to \
+         restore their keys."
+    )
+}
+
 /// How long the cold-start readiness gate waits for the wallet backend to wire
 /// before it stops retrying silently and surfaces a visible, actionable banner.
 ///
@@ -1850,6 +1865,7 @@ mod migration_banner_tests {
             MigrationStep::Shielded,
             MigrationStep::WalletSeeds,
             MigrationStep::WalletMeta,
+            MigrationStep::Identities,
             MigrationStep::Finalize,
         ] {
             let text = migration_running_text(step);
@@ -1873,6 +1889,7 @@ mod migration_banner_tests {
             migration_running_text(MigrationStep::Shielded),
             migration_running_text(MigrationStep::WalletSeeds),
             migration_running_text(MigrationStep::WalletMeta),
+            migration_running_text(MigrationStep::Identities),
             migration_running_text(MigrationStep::Finalize),
         ];
         let unique: std::collections::HashSet<&str> = labels.iter().copied().collect();

src/app/reconcilers.rs

@@ -33,8 +33,8 @@ use super::{
     COLD_START_BACKEND_READY_TIMEOUT, COLD_START_STUCK_MESSAGE, MIGRATION_RETRY_ACTION_ID,
     MIGRATION_VOTES_ACK_ACTION_ID, SPV_CONNECTING_DESCRIPTION, SPV_CONTINUE_BACKGROUND_ACTION,
     SPV_SYNCING_DESCRIPTION, SpvBlockStep, cold_start_backend_wait_timed_out,
-    migration_running_text, migration_unreadable_votes_text, should_dispatch_cold_start,
-    spv_block_step,
+    migration_running_text, migration_unreadable_identities_text, migration_unreadable_votes_text,
+    should_dispatch_cold_start, spv_block_step,
 };
 
 /// Drives platform-level accessibility (AccessKit) activation on the first
@@ -491,6 +491,19 @@ impl MigrationReconciler {
                 handle.with_action("Got it", MIGRATION_VOTES_ACK_ACTION_ID);
                 self.banner_handle = Some(handle);
             }
+            MigrationState::SucceededWithUnreadableIdentities { count } => {
+                // Same shape as the vote warning: the drain is done and the rows
+                // are still in the previous version's storage, so no retry action
+                // — but the keys those identities held are not loaded, so the user
+                // must be told even if they stepped away.
+                let handle = MessageBanner::set_global(
+                    ctx,
+                    migration_unreadable_identities_text(count),
+                    MessageType::Warning,
+                );
+                handle.disable_auto_dismiss();
+                self.banner_handle = Some(handle);
+            }
             MigrationState::Failed { error } => {
                 if error.is_backend_not_ready() {
                     // Transient: the wallet backend had not finished wiring when