fix(ui): wallet screen identity, state management, and input validation (#797)

docs/user-stories.md

@@ -186,6 +186,43 @@ As a user, I want to withdraw credits from a Platform address back to a Core add
 - Destination Core address input.
 - Fee strategy configuration.
 
+### WAL-021: Navigate wallet accounts via tabs [Implemented]
+**Persona:** Alex, Priya
+
+As a user, I want to see clear tabs for Dash Core, Platform, and Shielded so that I can switch between account views without searching through a dropdown.
+
+- Tab bar replaces account category dropdown.
+- Each tab shows its balance in the label.
+- Empty accounts display "(empty)" indicator.
+- Switching tabs is instant with no data reload.
+
+### WAL-022: View system accounts in developer mode [Implemented]
+**Persona:** Jordan
+
+As a developer, I want a System tab that reveals all internal account categories (Identity Registration, CoinJoin, Provider keys, etc.) so that I can inspect low-level wallet structure without cluttering the default view.
+
+- System tab appears only when developer mode is enabled.
+- Each system account category is shown as a collapsible section.
+- Section headers display address count and balance.
+
+### WAL-023: Collapsible transaction history [Implemented]
+**Persona:** Alex, Priya
+
+As a user, I want the transaction history to be collapsible so that I can focus on addresses or balances without scrolling past a long list of transactions.
+
+- Transaction history section has a collapsible header.
+- Collapsed by default to reduce visual clutter.
+- Expand/collapse state persists within the session.
+
+### WAL-024: Collapsible balance breakdown [Implemented]
+**Persona:** Priya
+
+As a power user, I want the balance breakdown and address table to be collapsible so that I can focus on the information I need at the moment.
+
+- Address table section has a collapsible header.
+- Asset locks section has a collapsible header.
+- Sections are expanded by default for quick access.
+
 ---
 
 ## Send and Receive (SND)

src/app.rs

@@ -820,6 +820,7 @@ impl AppState {
 
         // Warm up the Halo 2 ProvingKey in a background thread (~30s build).
         // This ensures the key is ready for the user's first shielded operation.
+        #[cfg(not(feature = "testing"))]
         std::thread::spawn(|| {
             let _ = crate::context::shielded::get_proving_key();
             tracing::info!("Halo 2 ProvingKey built and cached");

src/backend_task/core/mod.rs

@@ -197,11 +197,14 @@ impl AppContext {
                     if let Some(task_err) = Self::chain_lock_rpc_error(active_config, e) {
                         return Err(task_err);
                     }
-                    // Non-auth, non-connection error — log the raw error but show
-                    // a sanitized message in the UI status display.
+                    // Non-auth, non-connection error — show a sanitized message
+                    // in the Networks page status display for debugging.
                     tracing::warn!(network = ?self.network, error = %e, "Chain lock query failed on active network");
-                    Some("RPC error — check Dash Core status".to_string())
+                    Some(sanitize_rpc_error(&e.to_string()))
                 } else {
+                    // Successful chain lock fetch — clear any lingering RPC error
+                    // so the connection status recovers after a transient outage.
+                    self.connection_status.set_rpc_last_error(None);
                     None
                 };
 
@@ -694,17 +697,15 @@ impl AppContext {
 
         // Get UTXOs and change address from the wallet account
         let (utxos, change_index) = {
-            let managed_info =
-                wm.get_wallet_info(wallet_id)
-                    .ok_or_else(|| TaskError::WalletPaymentFailed {
-                        detail: "Wallet info unavailable".to_string(),
-                    })?;
+            let managed_info = wm
+                .get_wallet_info(wallet_id)
+                .ok_or(TaskError::WalletInfoUnavailable)?;
             let account = managed_info
                 .accounts()
                 .standard_bip44_accounts
                 .get(&DEFAULT_BIP44_ACCOUNT_INDEX)
-                .ok_or_else(|| TaskError::WalletPaymentFailed {
-                    detail: "BIP44 account missing".to_string(),
+                .ok_or(TaskError::MissingBip44Account {
+                    index: DEFAULT_BIP44_ACCOUNT_INDEX,
                 })?;
 
             let utxos: Vec<_> = account.utxos.values().cloned().collect();
@@ -714,21 +715,17 @@ impl AppContext {
 
         let wallet = wm
             .get_wallet(wallet_id)
-            .ok_or_else(|| TaskError::WalletPaymentFailed {
-                detail: "Wallet object not found".to_string(),
-            })?;
+            .ok_or(TaskError::WalletInfoUnavailable)?;
         let wallet_account = wallet
             .accounts
             .standard_bip44_accounts
             .get(&DEFAULT_BIP44_ACCOUNT_INDEX)
-            .ok_or_else(|| TaskError::WalletPaymentFailed {
-                detail: "BIP44 wallet account missing".to_string(),
+            .ok_or(TaskError::MissingBip44Account {
+                index: DEFAULT_BIP44_ACCOUNT_INDEX,
             })?;
         let change_addr = wallet_account
             .derive_change_address(change_index)
-            .map_err(|e| TaskError::WalletPaymentFailed {
-                detail: format!("Failed to derive change address: {e}"),
-            })?;
+            .map_err(|e| TaskError::ChangeAddressDerivation { source: e })?;
 
         loop {
             let scaled_recipients: Vec<(Address, u64)> = recipients
@@ -798,17 +795,15 @@ impl AppContext {
         account_index: u32,
         current_height: u32,
     ) -> Result<u64, TaskError> {
-        let managed_info =
-            wm.get_wallet_info(wallet_id)
-                .ok_or_else(|| TaskError::WalletPaymentFailed {
-                    detail: "Wallet info unavailable".to_string(),
-                })?;
+        let managed_info = wm
+            .get_wallet_info(wallet_id)
+            .ok_or(TaskError::WalletInfoUnavailable)?;
         let collection = managed_info.accounts();
         let account = collection
             .standard_bip44_accounts
             .get(&account_index)
-            .ok_or_else(|| TaskError::WalletPaymentFailed {
-                detail: "BIP44 account missing".to_string(),
+            .ok_or(TaskError::MissingBip44Account {
+                index: account_index,
             })?;
 
         let mut spendable_total = 0u64;
@@ -893,20 +888,16 @@ impl AppContext {
     ) -> Result<Transaction, TaskError> {
         let wallet = wm
             .get_wallet(wallet_id)
-            .ok_or_else(|| TaskError::WalletPaymentFailed {
-                detail: "Wallet object not found".to_string(),
-            })?;
-        let managed_info =
-            wm.get_wallet_info(wallet_id)
-                .ok_or_else(|| TaskError::WalletPaymentFailed {
-                    detail: "Wallet info unavailable".to_string(),
-                })?;
+            .ok_or(TaskError::WalletInfoUnavailable)?;
+        let managed_info = wm
+            .get_wallet_info(wallet_id)
+            .ok_or(TaskError::WalletInfoUnavailable)?;
         let accounts = managed_info.accounts();
         let account = accounts
             .standard_bip44_accounts
             .get(&DEFAULT_BIP44_ACCOUNT_INDEX)
-            .ok_or_else(|| TaskError::WalletPaymentFailed {
-                detail: "BIP44 account missing".to_string(),
+            .ok_or(TaskError::MissingBip44Account {
+                index: DEFAULT_BIP44_ACCOUNT_INDEX,
             })?;
 
         let secp = Secp256k1::new();
@@ -996,3 +987,29 @@ impl AppContext {
         size
     }
 }
+
+/// Sanitize raw RPC error strings for display in connection status.
+///
+/// Strips OS-level error details like "(os error 111)" and the "RPC error:"
+/// prefix noise, keeping only the meaningful description.
+fn sanitize_rpc_error(raw: &str) -> String {
+    let mut s = raw.to_string();
+
+    // Strip trailing OS error codes: "Connection refused (os error 111)" -> "Connection refused"
+    if let Some(pos) = s.find("(os error") {
+        s = s[..pos].trim_end().to_string();
+    }
+
+    // Strip nested "transport error:" or "JSON-RPC error:" wrappers
+    for prefix in &["transport error:", "JSON-RPC error:"] {
+        if let Some(pos) = s.find(prefix) {
+            s = s[pos + prefix.len()..].trim_start().to_string();
+        }
+    }
+
+    if s.is_empty() {
+        "Could not reach the node.".to_string()
+    } else {
+        format!("RPC: {s}")
+    }
+}

src/backend_task/error.rs

@@ -676,6 +676,21 @@ pub enum TaskError {
     #[error("Could not complete the payment. Please check your wallet balance and retry.")]
     WalletPaymentFailed { detail: String },
 
+    /// Could not access wallet information from the SPV manager.
+    #[error("Could not access wallet information. Please try again.")]
+    WalletInfoUnavailable,
+
+    /// Expected BIP44 account not found at the given index.
+    #[error("No BIP44 account found at the expected index. Please refresh your wallet.")]
+    MissingBip44Account { index: u32 },
+
+    /// Could not derive a change address from the wallet account.
+    #[error("Could not derive a change address. Please try again.")]
+    ChangeAddressDerivation {
+        #[source]
+        source: dash_sdk::dpp::key_wallet::Error,
+    },
+
     // ──────────────────────────────────────────────────────────────────────────
     // Token query errors (identity / recipient validation)
     // ──────────────────────────────────────────────────────────────────────────
@@ -830,6 +845,16 @@ pub enum TaskError {
         source: Box<dash_sdk::Error>,
     },
 
+    /// The nonce used for a shielded transaction was stale. The wallet's cached
+    /// nonce was behind Platform's expected nonce. Retrying will use the correct nonce.
+    #[error(
+        "The transaction used an outdated sequence number. Please retry — the wallet will use the correct number automatically."
+    )]
+    ShieldedNonceMismatch {
+        #[source]
+        source_error: Box<dash_sdk::Error>,
+    },
+
     /// The address used for a shielded transaction does not have enough locked funds.
     #[error(
         "Not enough funds locked for this shielded transaction. \
@@ -1006,6 +1031,13 @@ pub fn shielded_broadcast_error(e: SdkError) -> TaskError {
             source_error: Box::new(e),
         };
     }
+    if let Some(ConsensusError::StateError(StateError::AddressInvalidNonceError(_))) =
+        consensus_error
+    {
+        return TaskError::ShieldedNonceMismatch {
+            source_error: Box::new(e),
+        };
+    }
     TaskError::ShieldedBroadcastFailed {
         source: Box::new(e),
     }

src/backend_task/shielded/sync.rs

@@ -110,11 +110,31 @@ pub async fn sync_notes(
     }
 
     // Persist and record decrypted notes that are new (position >= already_have).
+    // Also skip notes already in memory (loaded from DB during init) to prevent
+    // double-counting when the commitment tree resets but persisted notes remain.
+    // Build a HashMap of position->value for O(1) lookups and divergence detection.
+    let existing_notes: std::collections::HashMap<u64, u64> = shielded_state
+        .notes
+        .iter()
+        .map(|n| (u64::from(n.position), n.note.value().inner()))
+        .collect();
     let mut new_note_count = 0u32;
     for dn in result.decrypted_notes {
         if dn.position < already_have {
             continue; // already stored in a previous sync
         }
+        if let Some(&existing_value) = existing_notes.get(&dn.position) {
+            let new_value = dn.note.value().inner();
+            if new_value != existing_value {
+                tracing::warn!(
+                    position = dn.position,
+                    existing_value,
+                    new_value,
+                    "Shielded note dedup: value divergence at existing position"
+                );
+            }
+            continue; // already loaded from DB during init
+        }
 
         // Compute the spending nullifier from our FVK (dn.nullifier is the rho/nf
         // field from the compact action, not the spending nullifier).

src/context/shielded.rs

@@ -150,7 +150,7 @@ impl AppContext {
     }
 
     /// Initialize shielded wallet state by deriving ZIP32 keys from the wallet seed.
-    fn initialize_shielded_wallet(
+    pub(crate) fn initialize_shielded_wallet(
         self: &Arc<Self>,
         seed_hash: WalletSeedHash,
     ) -> Result<BackendTaskSuccessResult, TaskError> {
@@ -277,7 +277,7 @@ impl AppContext {
     }
 
     /// Sync shielded notes from platform.
-    async fn sync_shielded_notes(
+    pub(crate) async fn sync_shielded_notes(
         self: &Arc<Self>,
         seed_hash: WalletSeedHash,
     ) -> Result<BackendTaskSuccessResult, TaskError> {
@@ -539,7 +539,7 @@ impl AppContext {
     }
 
     /// Check nullifiers to detect spent notes.
-    async fn check_nullifiers_task(
+    pub(crate) async fn check_nullifiers_task(
         self: &Arc<Self>,
         seed_hash: WalletSeedHash,
     ) -> Result<BackendTaskSuccessResult, TaskError> {