Skip to content

ci: add path filters to clippy and tests workflows #715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lklimek merged 2 commits into from
Mar 10, 2026
Merged

ci: add path filters to clippy and tests workflows #715

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2edb7bb
ci: add path filters to clippy and tests workflows
lklimek Mar 10, 2026
709b841
ci: include .cargo/config.toml in path filters
lklimek Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .github/workflows/clippy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,20 @@ on:
branches:
- main
- "v*-dev"
paths:
- "**/*.rs"
- "**/Cargo.toml"
- "Cargo.lock"
- ".cargo/config.toml"
- ".github/workflows/clippy.yml"
Comment thread
lklimek marked this conversation as resolved.
pull_request:
types: [opened, synchronize, reopened, ready_for_review]
paths:
- "**/*.rs"
- "**/Cargo.toml"
- "Cargo.lock"
- ".cargo/config.toml"
- ".github/workflows/clippy.yml"
Comment on lines +16 to +21

Copilot AI Mar 10, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The paths filters also omit .cargo/config.toml, which contains rustflags and linker configurations affecting how the code is compiled. A change to that file could affect clippy and test outcomes without triggering the workflows. Consider adding ".cargo/config.toml" to the paths list.

Copilot uses AI. Check for mistakes.
Comment on lines +8 to +21

Copilot AI Mar 10, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the "Tests" or "Clippy" workflows are configured as required status checks in the branch protection rules for main or v*-dev, adding paths filters will cause those checks to be skipped (not reported at all) when a PR only touches non-Rust files (e.g., docs, CI configs, assets). A skipped check does not satisfy a "required" check on GitHub, which would block merging such PRs.

The recommended mitigation is to add a lightweight "pass-through" job that runs when the path filter causes the workflow to be skipped, typically using a separate workflow triggered by workflow_run or by adding a fallback job with if: ${{ !needs.<job>.result }}. Alternatively, use a tool like dorny/paths-filter to conditionally skip individual jobs while keeping the workflow always triggered.

Suggested change
paths:
- "**/*.rs"
- "**/Cargo.toml"
- "Cargo.lock"
- ".github/workflows/clippy.yml"
pull_request:
types: [opened, synchronize, reopened, ready_for_review]
paths:
- "**/*.rs"
- "**/Cargo.toml"
- "Cargo.lock"
- ".github/workflows/clippy.yml"
pull_request:
types: [opened, synchronize, reopened, ready_for_review]

Copilot uses AI. Check for mistakes.

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
Expand Down
12 changes: 12 additions & 0 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,20 @@ on:
branches:
- main
- "v*-dev"
paths:
- "**/*.rs"
- "**/Cargo.toml"
- "Cargo.lock"
- ".cargo/config.toml"
- ".github/workflows/tests.yml"
Comment on lines +8 to +13

Copilot AI Mar 10, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The paths filters for both workflows omit rust-toolchain.toml, which pins the Rust toolchain version used by CI. A change to that file (e.g., bumping the toolchain version) would affect compilation and lint/test results but would not trigger these workflows. Consider adding "rust-toolchain.toml" to the paths list in both tests.yml and clippy.yml.

Copilot uses AI. Check for mistakes.
pull_request:
types: [opened, synchronize, reopened, ready_for_review]
paths:
- "**/*.rs"
- "**/Cargo.toml"
- "Cargo.lock"
- ".cargo/config.toml"
- ".github/workflows/tests.yml"
Comment on lines +8 to +21

Copilot AI Mar 10, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the "Tests" workflow is configured as a required status check in branch protection rules for main or v*-dev, adding paths filters will cause the check to be skipped (not reported) when a PR only touches non-Rust files. A skipped check does not satisfy a "required" check on GitHub, which would block merging such PRs.

The recommended mitigation is to add a lightweight pass-through job (e.g., always reporting success) for cases where the path filter causes the workflow to be skipped, or to use dorny/paths-filter to conditionally skip individual jobs while always triggering the workflow.

Copilot uses AI. Check for mistakes.
Comment thread
lklimek marked this conversation as resolved.

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
Expand Down
Loading