Skip to content

fix: remove dead code with guaranteed mutex deadlock #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lklimek merged 2 commits into from
Feb 11, 2026
Merged

fix: remove dead code with guaranteed mutex deadlock #559

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
216e22a
Initial plan
Copilot Feb 11, 2026
c591ea1
Remove unused insert_remote_identity_if_not_exists function with dead…
Copilot Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 0 additions & 33 deletions src/database/identities.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,39 +114,6 @@ impl Database {
Ok(())
}

#[allow(dead_code)] // May be used for caching remote identities from network queries
pub fn insert_remote_identity_if_not_exists(
&self,
identifier: &Identifier,
qualified_identity: Option<&QualifiedIdentity>,
app_context: &AppContext,
) -> rusqlite::Result<()> {
let id = identifier.to_vec();
let alias = qualified_identity.and_then(|qi| qi.alias.clone());
let identity_type =
qualified_identity.map_or("".to_string(), |qi| format!("{:?}", qi.identity_type));
let data = qualified_identity.map(|qi| qi.to_bytes());

let network = app_context.network.to_string();

// Check if the identity already exists
let conn = self.conn.lock().unwrap();
let mut stmt =
conn.prepare("SELECT COUNT(*) FROM identity WHERE id = ? AND network = ?")?;
let count: i64 = stmt.query_row(params![id, network], |row| row.get(0))?;

// If the identity doesn't exist, insert it
if count == 0 {
self.execute(
"INSERT INTO identity (id, data, is_local, alias, identity_type, network)
VALUES (?, ?, 0, ?, ?, ?)",
params![id, data, alias, identity_type, network],
)?;
}

Ok(())
}

pub fn get_local_qualified_identities(
&self,
app_context: &AppContext,
Expand Down
Loading