Skip to content

fix: security level validation for add key screen #494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pauldelucia merged 5 commits into from
Jan 23, 2026
Merged

fix: security level validation for add key screen #494

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d8afabe
fix: auto-set security level based on key purpose in add key screen
thephez Jan 22, 2026
dc4e969
fix: disable security level dropdown when only one option is valid
thephez Jan 22, 2026
f72bc18
Merge branch 'v1.0-dev' into fix-add-keys-flow
pauldelucia Jan 23, 2026
62362a7
fix: remove redundant `contract_bounds_enabled` check for `has_multip…
pauldelucia Jan 23, 2026
98bac4b
fmt
pauldelucia Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
118 changes: 84 additions & 34 deletions src/ui/identities/keys/add_key_screen.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,6 +404,7 @@ impl ScreenLike for AddKeyScreen {
.show(ui, |ui| {
// Purpose
ui.label("Purpose:");
let prev_purpose = self.purpose;
egui::ComboBox::from_id_salt("purpose_selector")
.selected_text(format!("{:?}", self.purpose))
.show_ui(ui, |ui| {
Expand Down Expand Up @@ -443,44 +444,93 @@ impl ScreenLike for AddKeyScreen {
);
}
});

// Auto-set security level when purpose changes
if self.purpose != prev_purpose {
match self.purpose {
Purpose::ENCRYPTION | Purpose::DECRYPTION => {
self.security_level = SecurityLevel::MEDIUM;
}
Purpose::TRANSFER => {
self.security_level = SecurityLevel::CRITICAL;
}
Purpose::AUTHENTICATION => {
// AUTHENTICATION allows multiple levels, keep current if valid
// otherwise default to CRITICAL
if self.security_level != SecurityLevel::CRITICAL
&& self.security_level != SecurityLevel::HIGH
&& self.security_level != SecurityLevel::MEDIUM
{
self.security_level = SecurityLevel::CRITICAL;
}
}
_ => {}
}
}
ui.end_row();

// Security Level
ui.label("Security Level:");
egui::ComboBox::from_id_salt("security_level_selector")
.selected_text(format!("{:?}", self.security_level))
.show_ui(ui, |ui| {
if self.enable_contract_bounds {
// When contract bounds are enabled, only allow MEDIUM
ui.selectable_value(
&mut self.security_level,
SecurityLevel::MEDIUM,
"MEDIUM",
);
} else if self.purpose == Purpose::AUTHENTICATION {
ui.selectable_value(
&mut self.security_level,
SecurityLevel::CRITICAL,
"CRITICAL",
);
ui.selectable_value(
&mut self.security_level,
SecurityLevel::HIGH,
"HIGH",
);
ui.selectable_value(
&mut self.security_level,
SecurityLevel::MEDIUM,
"MEDIUM",
);
} else {
ui.selectable_value(
&mut self.security_level,
SecurityLevel::CRITICAL,
"CRITICAL",
);
}
});
// Only AUTHENTICATION has multiple security level options
let has_multiple_security_levels = self.purpose == Purpose::AUTHENTICATION;
let inner_response = ui.add_enabled_ui(has_multiple_security_levels, |ui| {
egui::ComboBox::from_id_salt("security_level_selector")
.selected_text(format!("{:?}", self.security_level))
.show_ui(ui, |ui| {
if self.enable_contract_bounds {
// When contract bounds are enabled, only allow MEDIUM
ui.selectable_value(
&mut self.security_level,
SecurityLevel::MEDIUM,
"MEDIUM",
);
} else if self.purpose == Purpose::AUTHENTICATION {
ui.selectable_value(
&mut self.security_level,
SecurityLevel::CRITICAL,
"CRITICAL",
);
ui.selectable_value(
&mut self.security_level,
SecurityLevel::HIGH,
"HIGH",
);
ui.selectable_value(
&mut self.security_level,
SecurityLevel::MEDIUM,
"MEDIUM",
);
} else if self.purpose == Purpose::ENCRYPTION
|| self.purpose == Purpose::DECRYPTION
{
// ENCRYPTION and DECRYPTION only allow MEDIUM
ui.selectable_value(
&mut self.security_level,
SecurityLevel::MEDIUM,
"MEDIUM",
);
} else {
// TRANSFER only allows CRITICAL
ui.selectable_value(
&mut self.security_level,
SecurityLevel::CRITICAL,
"CRITICAL",
);
}
})
});
if !has_multiple_security_levels {
// Use interact with hover sense to detect hover on disabled widget
let hover_response = ui.interact(
inner_response.response.rect,
egui::Id::new("security_level_tooltip"),
egui::Sense::hover(),
);
hover_response.on_hover_text(format!(
"{:?} purpose requires {:?} security level",
self.purpose, self.security_level
));
}
ui.end_row();

// Key Type
Expand Down
Loading