Skip to content

fix: network mainnet was hardcoded for private_key_at_derivation_path #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pauldelucia wants to merge 6 commits into from
Closed

fix: network mainnet was hardcoded for private_key_at_derivation_path #327

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f2a5711
fix: network mainnet was hardcoded for private_key_at_derivation_path
pauldelucia Jun 5, 2025
53109c0
fix
pauldelucia Jun 5, 2025
12a4320
ok
pauldelucia Jun 6, 2025
9a4f626
Merge branch 'v0.9-dev' into fix/dynamic-network-for-private-key
pauldelucia Jun 9, 2025
ce4772b
Merge remote-tracking branch 'origin/v0.9-dev' into fix/dynamic-netwo…
lklimek Jun 11, 2025
003c640
chore: add network name to wallet
lklimek Jun 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/model/wallet/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,7 @@ impl Wallet {
if wallet_ref.seed_hash() == wallet_seed_hash {
// Attempt to derive the private key using the provided derivation path
let extended_private_key = derivation_path
.derive_priv_ecdsa_for_master_seed(wallet_ref.seed_bytes()?, Network::Dash)
.derive_priv_ecdsa_for_master_seed(wallet_ref.seed_bytes()?, Network::Dash) // Does this need to be dynamic network?
Comment thread
pauldelucia marked this conversation as resolved.
Resolved
.map_err(|e| e.to_string())?;
return Ok(Some(extended_private_key.private_key.secret_bytes()));
}
Expand All @@ -346,9 +346,10 @@ impl Wallet {
pub fn private_key_at_derivation_path(
&self,
derivation_path: &DerivationPath,
network: Network,
) -> Result<PrivateKey, String> {
let extended_private_key = derivation_path
.derive_priv_ecdsa_for_master_seed(self.seed_bytes()?, Network::Dash)
.derive_priv_ecdsa_for_master_seed(self.seed_bytes()?, network)
.map_err(|e| e.to_string())?;
Ok(extended_private_key.to_priv())
}
Expand Down
2 changes: 2 additions & 0 deletions src/ui/identities/keys/key_info_screen.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,7 @@ impl ScreenLike for KeyInfoScreen {
self.selected_wallet.as_ref().unwrap().read().unwrap();
match wallet.private_key_at_derivation_path(
&derivation_path.derivation_path,
self.app_context.network,
) {
Ok(private_key) => {
let private_key_wif = private_key.to_wif();
Expand Down Expand Up @@ -286,6 +287,7 @@ impl ScreenLike for KeyInfoScreen {
self.selected_wallet.as_ref().unwrap().read().unwrap();
match wallet.private_key_at_derivation_path(
&derivation_path.derivation_path,
self.app_context.network,
) {
Ok(private_key) => {
let private_key_wif = private_key.to_wif();
Expand Down