feat: add key selector to token config update screen - #251
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThis update introduces new documentation and licensing files for multiple Noto font families, expands the Changes
Sequence Diagram(s)sequenceDiagram
participant Developer
participant Environment
participant Application
Developer->>Environment: Adds/updates .env.example with Devnet and Local network configs
Developer->>Application: Runs application with selected environment variables
Application->>Environment: Reads environment variables for network configuration
Application->>Application: Applies network settings (DAPI, Core, RPC, Insight API)
Possibly related PRs
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Inline review comments failed to post. This is likely due to GitHub's limits when posting large numbers of comments. If you are seeing this consistently it is likely a permissions issue. Please check "Moderation" -> "Code review limits" under your organization settings.
Actionable comments posted: 4
🧹 Nitpick comments (17)
assets/Fonts/Noto_Sans_TC/README.txt (1)
12-14: Insert missing comma for clarity.Add a comma after “cases” to improve readability:
- Not all apps support variable fonts, and in those cases you can use the static font files for Noto Sans TC: + Not all apps support variable fonts, and in those cases, you can use the static font files for Noto Sans TC:🧰 Tools
🪛 LanguageTool
[formatting] ~13-~13: Consider inserting a comma after an introductory phrase for better readability.
Context: ...ot all apps support variable fonts, and in those cases you can use the static font files for N...(IN_THAT_CASE_COMMA)
assets/Fonts/Noto_Sans_JP/README.txt (1)
13-13: Refine introductory clause punctuation for clarity. Consider adding a comma after “in those cases” to improve readability:- Not all apps support variable fonts, and in those cases you can use the static font files for Noto Sans JP: + Not all apps support variable fonts, and in those cases, you can use the static font files for Noto Sans JP:🧰 Tools
🪛 LanguageTool
[formatting] ~13-~13: Consider inserting a comma after an introductory phrase for better readability.
Context: ...ot all apps support variable fonts, and in those cases you can use the static font files for N...(IN_THAT_CASE_COMMA)
assets/Fonts/Noto_Sans_KR/README.txt (1)
13-13: Refine introductory clause punctuation for clarity. Add a comma after “in those cases” to enhance readability:- Not all apps support variable fonts, and in those cases you can use the static font files for Noto Sans KR: + Not all apps support variable fonts, and in those cases, you can use the static font files for Noto Sans KR:🧰 Tools
🪛 LanguageTool
[formatting] ~13-~13: Consider inserting a comma after an introductory phrase for better readability.
Context: ...ot all apps support variable fonts, and in those cases you can use the static font files for N...(IN_THAT_CASE_COMMA)
assets/Fonts/Noto_Sans_SC/OFL.txt (1)
9-9: Use typographic en dash for date separator. Replace the hyphen with an en dash between the version and date to follow typographic conventions:- SIL OPEN FONT LICENSE Version 1.1 - 26 February 2007 + SIL OPEN FONT LICENSE Version 1.1 – 26 February 2007🧰 Tools
🪛 LanguageTool
[typographical] ~9-~9: If you want to indicate numerical ranges or time ranges, consider using an en dash.
Context: ...-----
SIL OPEN FONT LICENSE Version 1.1 - 26 February 2007
----------------------...(DASH_RULE)
assets/Fonts/Noto_Sans_SC/README.txt (1)
13-13: Refine introductory clause punctuation for clarity. Insert a comma after “in those cases” for better flow:- Not all apps support variable fonts, and in those cases you can use the static font files for Noto Sans SC: + Not all apps support variable fonts, and in those cases, you can use the static font files for Noto Sans SC:🧰 Tools
🪛 LanguageTool
[formatting] ~13-~13: Consider inserting a comma after an introductory phrase for better readability.
Context: ...ot all apps support variable fonts, and in those cases you can use the static font files for N...(IN_THAT_CASE_COMMA)
assets/Fonts/Noto_Sans_Devanagari/OFL.txt (1)
9-9: Use typographic en dash for date separator. Replace the hyphen with an en dash in the license header:- SIL OPEN FONT LICENSE Version 1.1 - 26 February 2007 + SIL OPEN FONT LICENSE Version 1.1 – 26 February 2007🧰 Tools
🪛 LanguageTool
[typographical] ~9-~9: If you want to indicate numerical ranges or time ranges, consider using an en dash.
Context: ...-----
SIL OPEN FONT LICENSE Version 1.1 - 26 February 2007
----------------------...(DASH_RULE)
assets/Fonts/Noto_Sans_Hebrew/OFL.txt (1)
9-9: Typographical refinement: use en dash for date range
Consider replacing the hyphen in the headerSIL OPEN FONT LICENSE Version 1.1 - 26 February 2007with an en dash (–) to more accurately denote the range, e.g.:
- SIL OPEN FONT LICENSE Version 1.1 - 26 February 2007 + SIL OPEN FONT LICENSE Version 1.1 – 26 February 2007🧰 Tools
🪛 LanguageTool
[typographical] ~9-~9: If you want to indicate numerical ranges or time ranges, consider using an en dash.
Context: ...-----
SIL OPEN FONT LICENSE Version 1.1 - 26 February 2007
----------------------...(DASH_RULE)
assets/Fonts/Noto_Sans_Khmer/OFL.txt (1)
9-9: Typographical refinement: use en dash for date range
Consider replacing the hyphen in the headerSIL OPEN FONT LICENSE Version 1.1 - 26 February 2007with an en dash (–) to more accurately denote the range, e.g.:
- SIL OPEN FONT LICENSE Version 1.1 - 26 February 2007 + SIL OPEN FONT LICENSE Version 1.1 – 26 February 2007🧰 Tools
🪛 LanguageTool
[typographical] ~9-~9: If you want to indicate numerical ranges or time ranges, consider using an en dash.
Context: ...-----
SIL OPEN FONT LICENSE Version 1.1 - 26 February 2007
----------------------...(DASH_RULE)
assets/Fonts/Noto_Sans_Khmer/README.txt (1)
14-14: Improve readability with commas around parenthetical phrase
In the sentenceNot all apps support variable fonts, and in those cases you can use the static font files for Noto Sans Khmer:consider adding commas to set off the parenthetical “in those cases,” for clarity:
- Not all apps support variable fonts, and in those cases you can use the static font files for Noto Sans Khmer: + Not all apps support variable fonts, and, in those cases, you can use the static font files for Noto Sans Khmer:🧰 Tools
🪛 LanguageTool
[formatting] ~14-~14: Consider inserting a comma after an introductory phrase for better readability.
Context: ...ot all apps support variable fonts, and in those cases you can use the static font files for N...(IN_THAT_CASE_COMMA)
assets/Fonts/Noto_Sans_Devanagari/README.txt (1)
14-14: Improve readability with commas around parenthetical phrase
In the sentenceNot all apps support variable fonts, and in those cases you can use the static font files for Noto Sans Devanagari:consider adding commas to set off the parenthetical “in those cases,” for clarity:
- Not all apps support variable fonts, and in those cases you can use the static font files for Noto Sans Devanagari: + Not all apps support variable fonts, and, in those cases, you can use the static font files for Noto Sans Devanagari:🧰 Tools
🪛 LanguageTool
[formatting] ~14-~14: Consider inserting a comma after an introductory phrase for better readability.
Context: ...ot all apps support variable fonts, and in those cases you can use the static font files for N...(IN_THAT_CASE_COMMA)
assets/Fonts/Noto_Sans_Arabic/README.txt (1)
14-14: Improve readability with commas around parenthetical phrase
In the sentenceNot all apps support variable fonts, and in those cases you can use the static font files for Noto Sans Arabic:consider adding commas to set off the parenthetical “in those cases,” for clarity:
- Not all apps support variable fonts, and in those cases you can use the static font files for Noto Sans Arabic: + Not all apps support variable fonts, and, in those cases, you can use the static font files for Noto Sans Arabic:🧰 Tools
🪛 LanguageTool
[formatting] ~14-~14: Consider inserting a comma after an introductory phrase for better readability.
Context: ...ot all apps support variable fonts, and in those cases you can use the static font files for N...(IN_THAT_CASE_COMMA)
assets/Fonts/Noto_Sans_Hebrew/README.txt (1)
14-15: Improve readability with a comma Consider adding a comma after “in those cases” for clarity:
“...and, in those cases, you can use the static font files for Noto Sans Hebrew:”🧰 Tools
🪛 LanguageTool
[formatting] ~14-~14: Consider inserting a comma after an introductory phrase for better readability.
Context: ...ot all apps support variable fonts, and in those cases you can use the static font files for N...(IN_THAT_CASE_COMMA)
assets/Fonts/Noto_Sans/README.txt (1)
14-15: Improve readability with a comma Insert a comma after “in those cases” for consistency:
“...and, in those cases, you can use the static font files for Noto Sans:”🧰 Tools
🪛 LanguageTool
[formatting] ~15-~15: Consider inserting a comma after an introductory phrase for better readability.
Context: ...ot all apps support variable fonts, and in those cases you can use the static font files for N...(IN_THAT_CASE_COMMA)
assets/Fonts/Noto_Sans_Thai/README.txt (1)
14-15: Improve readability with a comma Consider adding a comma after “in those cases” to enhance clarity:
“...and, in those cases, you can use the static font files for Noto Sans Thai:”🧰 Tools
🪛 LanguageTool
[formatting] ~14-~14: Consider inserting a comma after an introductory phrase for better readability.
Context: ...ot all apps support variable fonts, and in those cases you can use the static font files for N...(IN_THAT_CASE_COMMA)
Cargo.toml (2)
30-30: Consider moving off RC release
Pinningbincode = "=2.0.0-rc.3"ties you to a release candidate. If possible, upgrade to a stable2.0.0release once it's out to reduce dependency risk.
46-46: Update deprecated serde_yaml version
You're usingserde_yaml = "0.9.34+deprecated". To reduce technical debt, consider migrating to a maintained, non-deprecated version ofserde_yaml..gitignore (1)
26-26: Remove redundant .DS_Store pattern
You already ignore*.DS_Storeat line 23;**/.DS_Storeis redundant. Consolidate to a single pattern to simplify the file.
🛑 Comments failed to post (4)
assets/Fonts/Noto_Sans_TC/OFL.txt (1)
1-2:
⚠️ Potential issueCritical: Incorrect license header for Noto Sans TC.
The header currently reads:
Copyright 2014-2021 Adobe (http://www.adobe.com/), with Reserved Font Name 'Source'This appears to be borrowed from the Adobe Source license and does not match the Noto Sans TC font or its copyright holders.
Please update the header to reference the correct copyright (e.g., “The Noto Project Authors”)
and reserved font name for Noto Sans TC to ensure licensing accuracy.assets/Fonts/Noto_Sans_KR/OFL.txt (1)
1-2:
⚠️ Potential issueCritical: Incorrect license header for Noto Sans KR.
The header is still referencing Adobe and “Source,” which isn’t applicable to Noto Sans KR.
Please replace it with the appropriate copyright notice and reserved font name
for the Noto Sans KR font (e.g., “The Noto Project Authors”).assets/Fonts/Noto_Sans_JP/OFL.txt (1)
1-2:
⚠️ Potential issueCritical: Incorrect license header for Noto Sans JP.
The header still cites Adobe and “Source,” which does not match this font’s provenance.
Please update to the correct copyright holder (“The Noto Project Authors”)
and reserved font name for Noto Sans JP..github/workflows/release.yml (1)
33-33: 💡 Verification agent
❓ Verification inconclusive
Critical: Unknown runner label "ubuntu-22.04-arm"
The label"ubuntu-22.04-arm"is not one of the supported GitHub-hosted runner labels and will cause the job to never match a runner. If you intend to use a self-hosted ARM64 runner, either restore the self-hosted labels or declare this custom label in your actionlint config.Consider reverting to the previous self-hosted label set or using a valid GitHub-hosted runner. For example:
- runs-on: "ubuntu-22.04-arm" + # Use a self-hosted ARM64 runner with existing labels: + runs-on: + - self-hosted + - Linux + - ARM64 + - ubuntu-20.04
Fix invalid runner label in release workflow
The labelubuntu-22.04-armis not a supported GitHub-hosted runner and will never match. Choose one of the following fixes:
- Use a valid hosted runner:
- runs-on: "ubuntu-22.04-arm" + runs-on: ubuntu-22.04- Or restore your self-hosted ARM64 labels:
runs-on: - self-hosted - Linux - ARM64 - ubuntu-20.04• File: .github/workflows/release.yml, line 33
🧰 Tools
🪛 actionlint (1.7.4)
33-33: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
2 participants
Summary by CodeRabbit
New Features
Chores
.gitignoreto trackCargo.lockand ignore new files.