-
Notifications
You must be signed in to change notification settings - Fork 2
feat: add withdraw mode for platform credit asset unlocks #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
PastaPastaPasta
merged 4 commits into
main
from
claude/asset-unlocks-platform-withdrawals-93b0f4
Aug 15, 2026
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
cb3be32
feat: add withdraw mode for platform credit asset unlocks
PastaPastaPasta 4b5a72d
fix: address CodeRabbit review findings on withdraw mode
PastaPastaPasta e9abb86
fix: verify withdrawal landed before offering retry on submission errors
PastaPastaPasta 71ce1b2
fix: use exact protocol fee gate for Max, add key backup upload to wi…
PastaPastaPasta File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| import { describe, it, expect } from 'vitest'; | ||
|
|
||
| import { validateCoreAddress } from './address.js'; | ||
| import { base58CheckEncode } from '../utils/base58.js'; | ||
| import { TESTNET, MAINNET } from '../config.js'; | ||
|
|
||
| function makeAddress(prefix: number, fill = 0x42): string { | ||
| const payload = new Uint8Array(21); | ||
| payload[0] = prefix; | ||
| payload.fill(fill, 1); | ||
| return base58CheckEncode(payload); | ||
| } | ||
|
|
||
| describe('validateCoreAddress', () => { | ||
| it('accepts a testnet P2PKH address', () => { | ||
| const result = validateCoreAddress(makeAddress(TESTNET.addressPrefix), TESTNET); | ||
| expect(result).toEqual({ valid: true, type: 'p2pkh' }); | ||
| }); | ||
|
|
||
| it('accepts a testnet P2SH address', () => { | ||
| const result = validateCoreAddress(makeAddress(TESTNET.p2shPrefix), TESTNET); | ||
| expect(result).toEqual({ valid: true, type: 'p2sh' }); | ||
| }); | ||
|
|
||
| it('accepts mainnet P2PKH and P2SH addresses on mainnet', () => { | ||
| expect(validateCoreAddress(makeAddress(MAINNET.addressPrefix), MAINNET).valid).toBe(true); | ||
| expect(validateCoreAddress(makeAddress(MAINNET.p2shPrefix), MAINNET).valid).toBe(true); | ||
| }); | ||
|
|
||
| it('rejects a mainnet address on testnet with a wrong-network error', () => { | ||
| const result = validateCoreAddress(makeAddress(MAINNET.addressPrefix), TESTNET); | ||
| expect(result.valid).toBe(false); | ||
| expect(result.error).toContain('wrong network'); | ||
| }); | ||
|
|
||
| it('rejects a bech32m platform address with a targeted error', () => { | ||
| const result = validateCoreAddress( | ||
| 'tdash1qqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqq', | ||
| TESTNET | ||
| ); | ||
| expect(result.valid).toBe(false); | ||
| expect(result.error).toContain('Platform address'); | ||
| }); | ||
|
|
||
| it('rejects garbage and bad checksums', () => { | ||
| expect(validateCoreAddress('not-an-address', TESTNET).valid).toBe(false); | ||
| expect(validateCoreAddress('yYyYyYyYyYyYyYyYyYyYyYyYyYyYyYyYyY', TESTNET).valid).toBe(false); | ||
| expect(validateCoreAddress('', TESTNET).valid).toBe(false); | ||
| }); | ||
|
|
||
| it('rejects payloads that are not 21 bytes', () => { | ||
| const short = base58CheckEncode(new Uint8Array([TESTNET.addressPrefix, 1, 2, 3])); | ||
| const result = validateCoreAddress(short, TESTNET); | ||
| expect(result.valid).toBe(false); | ||
| expect(result.error).toContain('length'); | ||
| }); | ||
|
|
||
| it('trims surrounding whitespace', () => { | ||
| const addr = makeAddress(TESTNET.addressPrefix); | ||
| expect(validateCoreAddress(` ${addr} `, TESTNET).valid).toBe(true); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.