-
Notifications
You must be signed in to change notification settings - Fork 8
Implement parent_nodes + nth_child #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jonatanklosko
merged 17 commits into
dashbitco:main
from
spicychickensauce:construct-css-path
Oct 3, 2025
Merged
Changes from 6 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
ad68952
Implement parent_nodes
f52b687
Implement equals?
922e53b
Implement parent_node helper
f6a4964
Test construction of css path from node
a594dd9
Use singular parent_node as per library convention
50c0727
Avoid using numbers as ids
a98b1bc
Implement nth_child
83845cd
Simplify get_css_path by using nth_child
8669e1d
Use unordered_set instead of set
7e9d14e
Remove equals?
0594c3f
Make parent of fragment root nil instead of html
e2dbf91
Improve documentation of nth_child
spicychickensauce a4e7d69
Inline boolean expression
1b73ce7
Rename test helper to ancestor_chain
323deb7
Remove API guidance test function
9062d95
Don't include self in ancestor_chain
82de179
Remove unnecessary flat_map
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.