Rebased @eestrada 's changes on latest HTMLTestRunner version 3. #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rebased @eestrada 's changes on latest HTMLTestRunner version 3.
ghost
mentioned this pull request
HTMLTestRunner.py
Outdated
|
|
||
| row = self.REPORT_CLASS_TMPL % dict( | ||
| style = ne > 0 and 'errorClass' or nf > 0 and 'failClass' or 'passClass', | ||
| style = ne > 0 and 'errorClass' or nf > 0 and 'failClass' or ns and 'skipClass' or 'passClass', |
There was a problem hiding this comment.
Should be
ns > 0 and 'skipClass'
|
Can you also update test_HTMLTestRunner.py to reflect this new functionality which is optional and backward compatible? |
add skip testcase and cleanup the imports
|
did a few changes as you suggested. Maybe you can checkup on the conflict and resolve those issues ? |
|
@dark-passenger I just tried to push a commit to squash the conflict, but since it's your repo, I cannot. You'll need to resolve these yourself on your branch. The code itself looks good and there's no physical conflict after your rebase. Therefore it's only a repo tracking issue caused after the rebase. |
|
Closing pull request will resolve the conflict and send a fresh request. |
ghost
closed this
Conflicts: CHANGELOG.md
ghost
reopened this
|
resolved all conflicts. Should be good to go @dash0002 |
Rebased @eestrada 's changes on latest HTMLTestRunner version 3.
add skip testcase and cleanup the imports
dash0002
approved these changes
Oct 25, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.