ColorPaletteEditor: hide hotcue number column for track palette#52
Merged
daschuer merged 1 commit intodaschuer:color_preferencesfrom Apr 2, 2020
Merged
Conversation
It has no meaning in this context.
daschuer
requested changes
Mar 30, 2020
Owner
daschuer
left a comment
daschuer
left a comment
There was a problem hiding this comment.
As explained in the target PR the editor edits a type independent palette.
If you edit a palette from the track table edit button that is also used as Hotcue, the column is relevant. I like to keep it.
Owner
|
Ok, since a majority prefers this patch I will merge this now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It has no meaning in this context.