Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove unused imports from TWIRL templates and silence false positives #3351

Merged
merged 2 commits into from
Sep 2, 2024

Conversation

mpro7
Copy link
Contributor

@mpro7 mpro7 commented Sep 2, 2024

Pull Request Checklist

Task Description/Number

I've got annoyed by warns thrown by the complier therefore removed unused TWIRL imports.
Additionally silenced the false positive warnings coming from these templates which are not supported in Scala version we are using, but are again supported in Scala 3.5.0: scala/scala3#18783

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)
  • deprecated: Deprecation warning (ideally referencing a migration guide)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

@mpro7 mpro7 self-assigned this Sep 2, 2024
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.89%. Comparing base (6ebe8e7) to head (3a1dac4).
Report is 64 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3351      +/-   ##
==========================================
+ Coverage   83.04%   83.89%   +0.85%     
==========================================
  Files         290      295       +5     
  Lines       23087    23308     +221     
==========================================
+ Hits        19172    19555     +383     
+ Misses       3915     3753     -162     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mpro7 mpro7 changed the title chore: remove unused imports from TWIRL templates chore: Remove unused imports from TWIRL templates Sep 2, 2024
@mpro7 mpro7 changed the title chore: Remove unused imports from TWIRL templates chore: Remove unused imports from TWIRL templates and silence false positives Sep 2, 2024
@mpro7 mpro7 marked this pull request as ready for review September 2, 2024 08:55
Copy link
Contributor

@siers siers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean that fatal warnings can be enabled yet?

@mpro7
Copy link
Contributor Author

mpro7 commented Sep 2, 2024

Does this mean that fatal warnings can be enabled yet?

TBH have no idea. It would need to be checked in the release notes.

@mpro7 mpro7 merged commit 34f6ce8 into main Sep 2, 2024
11 checks passed
@mpro7 mpro7 deleted the clean-twirl-imports branch September 2, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants