This repository was archived by the owner on Feb 29, 2024. It is now read-only.
Delete increase_message_fee#207
Merged
Merged
Conversation
4ba7608 to
c266655
Compare
Member
|
Could you rebase this PR? @AsceticBear |
Member
Author
Give me mins. |
Member
Author
Checking sp-state-machine v0.12.0 (https://github.com/paritytech/substrate?branch=master#57e3486d)
error: `sp_trie::recorder::Recorder<H>::as_trie_recorder::{opaque#0}<'_>` does not live long enough
--> /home/bear/.cargo/git/checkouts/substrate-7e08433d4c370a21/57e3486/primitives/state-machine/src/trie_backend_essence.rs:181:44
|
181 | let recorder = recorder.as_mut().map(|r| r as _);
| ^
error: `sp_trie::recorder::Recorder<H>::as_trie_recorder::{opaque#0}<'_>` does not live long enough
--> /home/bear/.cargo/git/checkouts/substrate-7e08433d4c370a21/57e3486/primitives/state-machine/src/trie_backend_essence.rs:219:44
|
219 | let recorder = recorder.as_mut().map(|r| r as _);
| ^
There is still a compile issue in your branch. @AurevoirXavier |
Member
I could pass all the tests locally. |
aurexav
added a commit
that referenced
this pull request
Oct 19, 2022
* Refactor file structure * Refactor CI Signed-off-by: Xavier Lau <xavier@inv.cafe> * Remove unused constants * Remove unused primitives * Anchor `57e3486d9c7bb4deaef33cf9ba2da083b4e40314` * Update `bp-runtime` * Use latest toolchain * Update `bp-test-utils` * Update `bp-header-chain` * Update `bp-polkadot-core` * Downgrade versions * Format * Update `bp-message-dispatch` * Format * Update `pallet-bridge-grandpa` * Update `bp-parachains` * Update `bp-messages` * Format * Update `pallet-bridge-dispatch` * Update `pallet-bridge-parachains` * Update `bridge-runtime-common` part.1 * Update `instant_payments` * Update `weight_ext` * Update `outbound_lane` * Update `inbound_lane` * Update `pallet-messages` * Fixes * Update `bridge-runtime-common` part.1 * Update `bridge-runtime-common` part.2 * Format * Update `bridge-runtime-common` part.3 * Fix tests * Delete `increase_message_fee` (#207) * Delete useless call * Use call_index * Remove useless error types * Update * Format * Sync toolchain version * Remove useless code * Remove unused code * Remove unused code * Clean core primitives * Format * Add `pallets.rs` * Message pallet name for pangolin parachain alpha * Clean * Migrate pallet operation mode * Migrate best finalized * Handle all migrations * Remove unused code * License Signed-off-by: Xavier Lau <xavier@inv.cafe> Co-authored-by: bear <boundless.forest@outlook.com> Co-authored-by: Guantong <04637@163.com>
boundless-forest
added a commit
that referenced
this pull request
Oct 25, 2022
* Refactor file structure * Refactor CI Signed-off-by: Xavier Lau <xavier@inv.cafe> * Remove unused constants * Remove unused primitives * Anchor `57e3486d9c7bb4deaef33cf9ba2da083b4e40314` * Update `bp-runtime` * Use latest toolchain * Update `bp-test-utils` * Update `bp-header-chain` * Update `bp-polkadot-core` * Downgrade versions * Format * Update `bp-message-dispatch` * Format * Update `pallet-bridge-grandpa` * Update `bp-parachains` * Update `bp-messages` * Format * Update `pallet-bridge-dispatch` * Update `pallet-bridge-parachains` * Update `bridge-runtime-common` part.1 * Update `instant_payments` * Update `weight_ext` * Update `outbound_lane` * Update `inbound_lane` * Update `pallet-messages` * Fixes * Update `bridge-runtime-common` part.1 * Update `bridge-runtime-common` part.2 * Format * Update `bridge-runtime-common` part.3 * Fix tests * Delete `increase_message_fee` (#207) * Delete useless call * Use call_index * Remove useless error types * Update * Format * Sync toolchain version * Remove useless code * Remove unused code * Remove unused code * Clean core primitives * Format * Add `pallets.rs` * Message pallet name for pangolin parachain alpha * Clean * Migrate pallet operation mode * Migrate best finalized * Handle all migrations * Remove unused code * License Signed-off-by: Xavier Lau <xavier@inv.cafe> Co-authored-by: bear <boundless.forest@outlook.com> Co-authored-by: Guantong <04637@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #205
Please note this will change thereceive_messages_proofandreceive_messages_delivery_proof's call index, that's an incompatible change for bridges. A manual upgrade is required after the runtime upgrade.@fewensa I'll let you know when these changes are included in the runtime release afterward.