Skip to content
This repository was archived by the owner on Feb 29, 2024. It is now read-only.

Delete increase_message_fee#207

Merged
aurexav merged 6 commits into
xavier/latestfrom
bear-increase_message_fee
Oct 13, 2022
Merged

Delete increase_message_fee#207
aurexav merged 6 commits into
xavier/latestfrom
bear-increase_message_fee

Conversation

@boundless-forest
Copy link
Copy Markdown
Member

@boundless-forest boundless-forest commented Oct 9, 2022

Fix #205

Please note this will change the receive_messages_proof and receive_messages_delivery_proof's call index, that's an incompatible change for bridges. A manual upgrade is required after the runtime upgrade.

@fewensa I'll let you know when these changes are included in the runtime release afterward.

@boundless-forest boundless-forest marked this pull request as ready for review October 9, 2022 06:57
@boundless-forest boundless-forest marked this pull request as draft October 10, 2022 02:24
@boundless-forest boundless-forest marked this pull request as ready for review October 10, 2022 03:15
@boundless-forest boundless-forest changed the base branch from main to xavier/latest October 11, 2022 03:12
@aurexav
Copy link
Copy Markdown
Member

aurexav commented Oct 13, 2022

Could you rebase this PR? @AsceticBear

@boundless-forest
Copy link
Copy Markdown
Member Author

Could you rebase this PR? @AsceticBear

Give me mins.

@boundless-forest
Copy link
Copy Markdown
Member Author

   Checking sp-state-machine v0.12.0 (https://github.com/paritytech/substrate?branch=master#57e3486d)
error: `sp_trie::recorder::Recorder<H>::as_trie_recorder::{opaque#0}<'_>` does not live long enough
   --> /home/bear/.cargo/git/checkouts/substrate-7e08433d4c370a21/57e3486/primitives/state-machine/src/trie_backend_essence.rs:181:44
    |
181 |         let recorder = recorder.as_mut().map(|r| r as _);
    |                                                  ^

error: `sp_trie::recorder::Recorder<H>::as_trie_recorder::{opaque#0}<'_>` does not live long enough
   --> /home/bear/.cargo/git/checkouts/substrate-7e08433d4c370a21/57e3486/primitives/state-machine/src/trie_backend_essence.rs:219:44
    |
219 |         let recorder = recorder.as_mut().map(|r| r as _);
    |                                                  ^

There is still a compile issue in your branch. @AurevoirXavier

@aurexav
Copy link
Copy Markdown
Member

aurexav commented Oct 13, 2022

   Checking sp-state-machine v0.12.0 (https://github.com/paritytech/substrate?branch=master#57e3486d)
error: `sp_trie::recorder::Recorder<H>::as_trie_recorder::{opaque#0}<'_>` does not live long enough
   --> /home/bear/.cargo/git/checkouts/substrate-7e08433d4c370a21/57e3486/primitives/state-machine/src/trie_backend_essence.rs:181:44
    |
181 |         let recorder = recorder.as_mut().map(|r| r as _);
    |                                                  ^

error: `sp_trie::recorder::Recorder<H>::as_trie_recorder::{opaque#0}<'_>` does not live long enough
   --> /home/bear/.cargo/git/checkouts/substrate-7e08433d4c370a21/57e3486/primitives/state-machine/src/trie_backend_essence.rs:219:44
    |
219 |         let recorder = recorder.as_mut().map(|r| r as _);
    |                                                  ^

There is still a compile issue in your branch. @AurevoirXavier

I could pass all the tests locally.

@aurexav aurexav merged commit 6c44656 into xavier/latest Oct 13, 2022
@aurexav aurexav deleted the bear-increase_message_fee branch October 13, 2022 12:09
aurexav added a commit that referenced this pull request Oct 19, 2022
* Refactor file structure

* Refactor CI

Signed-off-by: Xavier Lau <xavier@inv.cafe>

* Remove unused constants

* Remove unused primitives

* Anchor `57e3486d9c7bb4deaef33cf9ba2da083b4e40314`

* Update `bp-runtime`

* Use latest toolchain

* Update `bp-test-utils`

* Update `bp-header-chain`

* Update `bp-polkadot-core`

* Downgrade versions

* Format

* Update `bp-message-dispatch`

* Format

* Update `pallet-bridge-grandpa`

* Update `bp-parachains`

* Update `bp-messages`

* Format

* Update `pallet-bridge-dispatch`

* Update `pallet-bridge-parachains`

* Update `bridge-runtime-common` part.1

* Update `instant_payments`

* Update `weight_ext`

* Update `outbound_lane`

* Update `inbound_lane`

* Update `pallet-messages`

* Fixes

* Update `bridge-runtime-common` part.1

* Update `bridge-runtime-common` part.2

* Format

* Update `bridge-runtime-common` part.3

* Fix tests

* Delete `increase_message_fee` (#207)

* Delete useless call

* Use call_index

* Remove useless error types

* Update

* Format

* Sync toolchain version

* Remove useless code

* Remove unused code

* Remove unused code

* Clean core primitives

* Format

* Add `pallets.rs`

* Message pallet name for pangolin parachain alpha

* Clean

* Migrate pallet operation mode

* Migrate best finalized

* Handle all migrations

* Remove unused code

* License

Signed-off-by: Xavier Lau <xavier@inv.cafe>
Co-authored-by: bear <boundless.forest@outlook.com>
Co-authored-by: Guantong <04637@163.com>
boundless-forest added a commit that referenced this pull request Oct 25, 2022
* Refactor file structure

* Refactor CI

Signed-off-by: Xavier Lau <xavier@inv.cafe>

* Remove unused constants

* Remove unused primitives

* Anchor `57e3486d9c7bb4deaef33cf9ba2da083b4e40314`

* Update `bp-runtime`

* Use latest toolchain

* Update `bp-test-utils`

* Update `bp-header-chain`

* Update `bp-polkadot-core`

* Downgrade versions

* Format

* Update `bp-message-dispatch`

* Format

* Update `pallet-bridge-grandpa`

* Update `bp-parachains`

* Update `bp-messages`

* Format

* Update `pallet-bridge-dispatch`

* Update `pallet-bridge-parachains`

* Update `bridge-runtime-common` part.1

* Update `instant_payments`

* Update `weight_ext`

* Update `outbound_lane`

* Update `inbound_lane`

* Update `pallet-messages`

* Fixes

* Update `bridge-runtime-common` part.1

* Update `bridge-runtime-common` part.2

* Format

* Update `bridge-runtime-common` part.3

* Fix tests

* Delete `increase_message_fee` (#207)

* Delete useless call

* Use call_index

* Remove useless error types

* Update

* Format

* Sync toolchain version

* Remove useless code

* Remove unused code

* Remove unused code

* Clean core primitives

* Format

* Add `pallets.rs`

* Message pallet name for pangolin parachain alpha

* Clean

* Migrate pallet operation mode

* Migrate best finalized

* Handle all migrations

* Remove unused code

* License

Signed-off-by: Xavier Lau <xavier@inv.cafe>
Co-authored-by: bear <boundless.forest@outlook.com>
Co-authored-by: Guantong <04637@163.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

increase_message_fee is not applicable to the fee-market design.

2 participants