Skip to content
This repository was archived by the owner on Feb 29, 2024. It is now read-only.

Remove rewardbook#122

Closed
wuminzhe wants to merge 2 commits into
mainfrom
aki-remove-rewardbook
Closed

Remove rewardbook#122
wuminzhe wants to merge 2 commits into
mainfrom
aki-remove-rewardbook

Conversation

@wuminzhe
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown
Contributor

@hackfisher hackfisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AsceticBear please help review this.

OrderReward(LaneId, MessageNonce, RewardItem<T::AccountId, BalanceOf<T, I>>),
/// Reward distribute of the order. \[lane_id, message_nonce, to_treasury, to_slot_relayer,
/// to_message_relayer, to_confirm_relayer\]
OrderReward(
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JayJay1024 Are you good with this event changes?

@boundless-forest boundless-forest marked this pull request as draft July 26, 2022 07:01
@boundless-forest
Copy link
Copy Markdown
Member

I’ll deal with this pr after #169 merged since there is some conflict.

Option<BalanceOf<T, I>>,
Option<(T::AccountId, BalanceOf<T, I>)>,
(T::AccountId, BalanceOf<T, I>),
BalanceOf<T, I>,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here it seems that only amount but no account information for to_confirm_relayer ?

@boundless-forest
Copy link
Copy Markdown
Member

I have done this in the #169 , Close this one

@wuminzhe wuminzhe deleted the aki-remove-rewardbook branch August 5, 2022 09:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

No open projects
Status: No status

Development

Successfully merging this pull request may close these issues.

Another way would be directly iterate though RewardItem and calculate the value wanted. RewardBook can be removed then.

4 participants