This repository was archived by the owner on Mar 20, 2024. It is now read-only.
Refactor s2s bridge#467
Merged
Merged
Conversation
# Conflicts: # frame/assistants/client-pangolin/Cargo.toml # frame/assistants/client-pangolin/src/client.rs # frame/assistants/client-pangolin/src/error.rs # frame/assistants/client-pangoro/src/component.rs
# Conflicts: # bridges/pangolin-pangoro/Cargo.lock # frame/assistants/client-pangolin/Cargo.toml
Contributor
|
How to update the Cargo.lock in bridges folder in one command? |
Contributor
Author
Have two ways:
|
fewensa
requested review from
furoxr,
hackfisher and
wuminzhe
and removed request for
furoxr
Contributor
|
Which s2s bridges are refactored to use the new approach? All of them or some of them? |
Contributor
Author
I updated the pull request description, this pull request only include bridge pangolin-pangoro |
2 tasks
hackfisher
reviewed
Jun 14, 2022
hackfisher
reviewed
Jun 14, 2022
hackfisher
reviewed
Jun 14, 2022
hackfisher
reviewed
Jun 14, 2022
hackfisher
approved these changes
Jun 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor s2s bridge.
This pr is an exploration of s2s bridge implementations. also only includes the delivery of messages.
Just include bridge pangolin-pangoro, other s2s bridges and other features (such as feemarket/docs) will be improved in the future.