Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grouping of skeletons by constraints #1628

Merged
merged 1 commit into from
Dec 18, 2021
Merged

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Dec 18, 2021


Before creating a pull request

  • Document new methods and classes
  • Format new code files using clang-format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change

@jslee02 jslee02 added this to the DART 6.13.0 milestone Dec 18, 2021
@codecov
Copy link

codecov bot commented Dec 18, 2021

Codecov Report

Merging #1628 (9637b02) into main (6f9feed) will decrease coverage by 0.00%.
The diff coverage is 36.36%.

@@            Coverage Diff             @@
##             main    #1628      +/-   ##
==========================================
- Coverage   58.92%   58.91%   -0.01%     
==========================================
  Files         477      477              
  Lines       40178    40178              
==========================================
- Hits        23673    23670       -3     
- Misses      16505    16508       +3     
Impacted Files Coverage Δ
dart/constraint/JointLimitConstraint.cpp 0.00% <0.00%> (ø)
dart/constraint/ServoMotorConstraint.cpp 0.00% <0.00%> (ø)
dart/constraint/SoftContactConstraint.cpp 0.00% <0.00%> (ø)
dart/constraint/WeldJointConstraint.cpp 6.59% <0.00%> (ø)
dart/dynamics/detail/DegreeOfFreedomPtr.hpp 85.07% <ø> (ø)
dart/constraint/BallJointConstraint.cpp 67.61% <50.00%> (ø)
dart/constraint/JointConstraint.cpp 73.58% <100.00%> (ø)
dart/constraint/JointCoulombFrictionConstraint.cpp 82.45% <100.00%> (ø)
dart/constraint/MimicMotorConstraint.cpp 80.32% <100.00%> (ø)
dart/dynamics/EulerJoint.cpp 70.17% <0.00%> (-2.93%) ⬇️
... and 1 more

@jslee02 jslee02 marked this pull request as ready for review December 18, 2021 15:07
@jslee02 jslee02 merged commit 56d7cbe into main Dec 18, 2021
@jslee02 jslee02 deleted the fix_constraint_grouping branch December 18, 2021 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant