-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Python bindings for CollisionFilter #1465
Conversation
# Conflicts: # python/dartpy/collision/CollisionObject.cpp
fd77765
to
9d811f8
Compare
Codecov Report
@@ Coverage Diff @@
## master #1465 +/- ##
==========================================
- Coverage 58.21% 58.21% -0.01%
==========================================
Files 412 412
Lines 29911 29913 +2
==========================================
+ Hits 17414 17415 +1
- Misses 12497 12498 +1
|
@jslee02 this PR causes python bindings on my system (Xubuntu 18.04) to fail with segfault everytime I do |
Did it work on your system before this PR?
Yes: https://github.com/dartsim/dart/runs/665747409#step:4:583 |
Yes and I tried again going back to a previous commit and it is working again.
I am using Ubuntu 18.04, but they still pass in your CIs. Any ideas on what I can check? I could do a debug build and see if I can find something in the trace but I doubt it. |
@jslee02 in arch-linux I am getting the following when doing
Again, if I revert to a previous commit, it is working. |
@jslee02 after cleaning up the cmake build folder and re-configuring, it seems that it is working. So, I guess it was a CMake thing.. Sorry for the fuzz.. |
Glad it worked! |
This PR is created based on #1457.
Before creating a pull request
clang-format
Before merging a pull request
CHANGELOG.md