Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in wrappers of dartpy Skeletons #1392

Merged
merged 1 commit into from
Aug 15, 2019

Conversation

chhinze
Copy link
Contributor

@chhinze chhinze commented Aug 15, 2019

getGravityForces() and getExternalForces() are fixed in
dartpy.dynamics.MetaSkeleton and dartpy.dynamics.Skeleton.
The wrong functions were called.


Before creating a pull request

  • Document new methods and classes
  • Format new code files using clang-format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change

`getGravityForces()` and `getExternalForces()` are fixed in
dartpy.dynamics.MetaSkeleton and dartpy.dynamics.Skeleton.
@codecov
Copy link

codecov bot commented Aug 15, 2019

Codecov Report

Merging #1392 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1392   +/-   ##
=======================================
  Coverage   57.27%   57.27%           
=======================================
  Files         366      366           
  Lines       27432    27432           
=======================================
  Hits        15711    15711           
  Misses      11721    11721

@jslee02 jslee02 added this to the DART 6.10.0 milestone Aug 15, 2019
Copy link
Member

@jslee02 jslee02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably these are replication errors. Good catch!

@jslee02 jslee02 merged commit 7978ebb into dartsim:master Aug 15, 2019
@chhinze chhinze deleted the fix/pySkeletonWrongGravity branch August 16, 2019 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants