Remove built_value dependency from DebugInfo #2739
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkonyi
approved these changes
Jan 7, 2026
nshahan
approved these changes
Jan 8, 2026
| extensionUrl: windowContext['\$dartExtensionUri'] as String?, | ||
| isInternalBuild: windowContext['\$isInternalBuild'] as bool?, | ||
| isFlutterApp: windowContext['\$isFlutterApp'] as bool?, | ||
| ).toJson(), |
Contributor
There was a problem hiding this comment.
Do we need to call .toJson() on the value passed t jsonEncode()? I'm not super familiar with the best practices here so maybe this is normal but it seems unnecessary based on the docs.
Contributor
Author
There was a problem hiding this comment.
You're absolutely right! Calling .toJson() before passing to jsonEncode() is redundant. Thanks
| final json = value is String | ||
| ? value | ||
| : value is DebugInfo | ||
| ? jsonEncode(value.toJson()) |
dwds/web/client.dart
Outdated
| isInternalBuild: windowContext.$isInternalBuild, | ||
| isFlutterApp: windowContext.$isFlutterApp, | ||
| workspaceName: dartWorkspaceName, | ||
| ).toJson(), |
Contributor
Author
|
Note: The callstack test failures are unrelated to this PR. They appear to be a regression in the current SDK dev release (3.11.0-260.0.dev) used by the bots, as they do not reproduce on the main branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DebugInfo:
This PR removes the
package:built_valuedependency fromDebugInfoand replaces it with standard Dart JSON serialization.Changes
DebugInfoas a simple Dart class with manual JSON serializationDebugInfofrom the@SerializersForannotation in serializers.darttoJson()for serialization instead of the builder patternDebugInfoserialization/deserialization:serializers.deserializetoDebugInfo.fromJson()toJson()DebugInfoininterceptMessage<T>()DebugInfoin storage operationsdebug_info.g.dartTesting
ConnectRequest,HotReloadRequest,HotReloadResponse,HotRestartRequest,HotRestartResponse,ServiceExtensionRequest, andServiceExtensionResponseFixes dart-lang/sdk#62295