Remove built_value dependency from ConnectRequest #2736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
autosubmit label was removed for dart-lang/webdev/2736, because - The status or check suite unit_test; windows; Dart dev; PKG: dwds; `dart test --total-shards 3 --shard-index 2 --exclude-ta... has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
nshahan
approved these changes
Jan 6, 2026
Comment on lines
148
to
159
| if (request is ConnectRequest) { | ||
| return ['ConnectRequest', request.toJson()]; | ||
| } else if (request is HotReloadRequest) { | ||
| return ['HotReloadRequest', request.toJson()]; | ||
| } else if (request is HotRestartRequest) { | ||
| return ['HotRestartRequest', request.toJson()]; | ||
| } else if (request is ServiceExtensionRequest) { | ||
| return ['ServiceExtensionRequest', request.toJson()]; | ||
| } else if (request is Map) { | ||
| // Already a raw message (e.g., ping) | ||
| return request; | ||
| } |
Contributor
There was a problem hiding this comment.
optional: We could make this a switch statement over the types. Then in the future we could potentially use a sealed class hierarchy to be sure we are properly handling all the different requests and get feedback from the compiler when we accidentally miss one.
https://dart.dev/language/branches#exhaustiveness-checking
bkonyi
approved these changes
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConnectRequest:
This PR removes the
package:built_valuedependency fromConnectRequestand replaces it with standard Dart JSON serialization.Changes
ConnectRequestas a simple Dart class with manual JSON serializationConnectRequestfrom the@SerializersForannotation in serializers.dartConnectRequestusing the wire format['ConnectRequest', request.toJson()]in_serializeMessage()and_deserializeMessage()ConnectRequestusing wire format in_sendConnectRequest()and addedConnectRequestcase to_deserializeEvent()helperconnect_request.g.dartTesting
HotReloadRequest,HotReloadResponse,HotRestartRequest,HotRestartResponse,ServiceExtensionRequest, andServiceExtensionResponseFixes dart-lang/sdk#62293