Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pkg-mime] contenttype to ext #431

Merged
merged 38 commits into from
Sep 11, 2024
Merged

[pkg-mime] contenttype to ext #431

merged 38 commits into from
Sep 11, 2024

Commits on Aug 26, 2024

  1. initial code from pr !15

    @mx1up
    mx1up committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    9355522 View commit details
    Browse the repository at this point in the history

  2. update copyright year

    @mx1up
    mx1up committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    e7f328e View commit details
    Browse the repository at this point in the history

  3. improve lookup: case-insensitive and use firstWhereOrNull instead of … 

    …for loop
    @mx1up
    mx1up committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    7eb72c3 View commit details
    Browse the repository at this point in the history

  4. tests cleanup

    @mx1up
    mx1up committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    80079be View commit details
    Browse the repository at this point in the history

  5. check baseline

    @mx1up
    mx1up committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    d3ce7ae View commit details
    Browse the repository at this point in the history

  6. test to check whether each mimetype with multiple extensions has a pr… 

    …eferred extension defined
    @mx1up
    mx1up committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    29050ff View commit details
    Browse the repository at this point in the history

  7. reformat

    @mx1up
    mx1up committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    84f3bd8 View commit details
    Browse the repository at this point in the history

  8. apparently, the function already existed :roll-eyes: but the preferre… 

    …d extension not. for backwards compatibility: add `extensionFromMimeOrNull`, and add an `orElse` param for `extensionFromMime` as the standard behavior results in creating an invalid filename.
    @mx1up
    mx1up committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    c27fa37 View commit details
    Browse the repository at this point in the history

  9. probably better not to enforce a preferred extension for mime types w… 

    …ith multiple extensions. There are quite some, but most of them are legacy, and new mimetypes tend to map to 1 extension (no 3 chars limit anymore), so less useful in the future
    @mx1up
    mx1up committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    f2a62f7 View commit details
    Browse the repository at this point in the history

  10. added some preferred extensions for common file formats

    @mx1up
    mx1up committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    bdb76d3 View commit details
    Browse the repository at this point in the history

  11. cleanup old tests

    @mx1up
    mx1up committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    16f54d5 View commit details
    Browse the repository at this point in the history

  12. test orElse param for unknown mime type

    @mx1up
    mx1up committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    dccafc0 View commit details
    Browse the repository at this point in the history

  13. link to file

    @mx1up
    mx1up committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    59c6ec2 View commit details
    Browse the repository at this point in the history

  14. fix title to be more accurate

    @mx1up
    mx1up committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    9e4b9d0 View commit details
    Browse the repository at this point in the history

  15. rename to existing function

    @mx1up
    mx1up committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    bc90ebd View commit details
    Browse the repository at this point in the history

  16. add standard behavior to make example more clear

    @mx1up
    mx1up committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    cd5e501 View commit details
    Browse the repository at this point in the history

  17. include text/plain mapping again

    @mx1up
    mx1up committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    557520e View commit details
    Browse the repository at this point in the history

  18. remove collection dependency

    @mx1up
    mx1up committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    8c1f0a0 View commit details
    Browse the repository at this point in the history

  19. lookupExtension has been renamed to existing extensionFromMime

    @mx1up
    mx1up committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    0701165 View commit details
    Browse the repository at this point in the history

  20. drop non-nullable extensionFromMime variant per review suggestion

    @mx1up
    mx1up committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    7ad3723 View commit details
    Browse the repository at this point in the history

  21. doc update: try using noun phrase; don't refer to implementation details

    @mx1up
    mx1up committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    58ad484 View commit details
    Browse the repository at this point in the history

  22. don't use extension method

    @mx1up
    mx1up committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    eed2ba9 View commit details
    Browse the repository at this point in the history

  23. remove addMimeType and leave it for another time..

    @mx1up
    mx1up committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    dc5db0b View commit details
    Browse the repository at this point in the history

  24. remove addMimeType documentation

    @mx1up
    mx1up committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    d285aae View commit details
    Browse the repository at this point in the history

  25. be more specific about extension

    @mx1up
    mx1up committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    342b63f View commit details
    Browse the repository at this point in the history

  26. review feedback: avoid abbreviations, just overwrite function param

    @mx1up
    mx1up committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    40cd80c View commit details
    Browse the repository at this point in the history

  27. since extensions can no longer by added at runtime, we can optimize a… 

    …nd avoid the linear search
    @mx1up
    mx1up committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    60730a6 View commit details
    Browse the repository at this point in the history

  28. local var no longer needed

    @mx1up
    mx1up committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    04f8169 View commit details
    Browse the repository at this point in the history

  29. update docs

    @mx1up
    mx1up committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    8ba5efb View commit details
    Browse the repository at this point in the history

  30. update docs

    @mx1up
    mx1up committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    c1d7b69 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. documentation updates

    @mx1up
    mx1up committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    e654a32 View commit details
    Browse the repository at this point in the history

  2. remove unnecessary addAll

    @mx1up
    mx1up committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    c236bd8 View commit details
    Browse the repository at this point in the history

  3. remove unnecessary group

    @mx1up
    mx1up committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    b11854c View commit details
    Browse the repository at this point in the history

  4. bump version + add changelog

    @mx1up
    mx1up committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    874f740 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. remove superfluous line

    @mx1up
    mx1up committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    d5e3d47 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2024

  1. breaking release because of removed method

    @mx1up
    mx1up committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    7b3193f View commit details
    Browse the repository at this point in the history

  2. add some more default extensions

    @mx1up
    mx1up committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    c33a7ea View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2024

  1. document breaking change correctly

    @mx1up
    mx1up committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    b5e6981 View commit details
    Browse the repository at this point in the history