Skip to content

Use -- to separate chrome URLs #2475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
natebosch merged 5 commits into from
Jul 29, 2026
Merged

Use -- to separate chrome URLs #2475

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ccc5f70
Use -- to separate chrome URLs
natebosch Jul 22, 2026
592e585
Only append when there is at least on URL
natebosch Jul 22, 2026
6800ccf
Assert args doesn't already have a separator
natebosch Jul 24, 2026
c7879f4
Add changelog entry
natebosch Jul 24, 2026
ffe6f59
Style tweak
natebosch Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkgs/browser_launcher/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
- Add `--test-type` and `--disable-session-crashed-bubble` flags when launching
chrome to prevent some warnings.
- Allow passing arbitrary command line arguments when starting Chrome.
- Separate CLI arguments from URLs with a `--` when launching Chrome.

## 1.1.3

Expand Down
19 changes: 6 additions & 13 deletions pkgs/browser_launcher/lib/src/chrome.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,12 +129,10 @@ class Chrome {
// another, don't announce when the previous session crashed.
'--disable-session-crashed-bubble',
...additionalArguments,
if (headless) '--headless',
];
if (headless) {
args.add('--headless');
}

final process = await _startProcess(urls, args: args);
final process = await start(urls, args: args);

// Wait until the DevTools are listening before trying to connect.
final errorLines = <String>[];
Expand Down Expand Up @@ -177,15 +175,10 @@ class Chrome {
static Future<Process> start(
List<String> urls, {
List<String> args = const [],
}) async =>
await _startProcess(urls, args: args);

static Future<Process> _startProcess(
List<String> urls, {
List<String> args = const [],
}) async {
final processArgs = args.toList()..addAll(urls);
return await Process.start(_executable, processArgs);
}) {
assert(!args.contains('--'));
assert(!urls.contains('--'));
return Process.start(_executable, [...args, '--', ...urls]);
}

static Future<Chrome> _connect(Chrome chrome) async {
Expand Down
Loading