Guarantee Safe First Click & Improve Bomb Placement #109
+193
−31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes
Game
class to guarantee the first click is never a bomb (standard Minesweeper behavior).Field.withSafePosition()
factory using an efficient O(n) shuffle algorithm for bomb placement, replacing the old do-while loop.game.width
,game.height
,game.bombCount
) instead of accessinggame.field
before the field is generated.Why
Issues