Copy expect and async matchers from test package #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Copy most of the `test_api/frontend` directory, except for the test related to the scaffolding functions. - Modify code to follow some stricter lints in the matcher package - avoid implicit `dynamic` arguments, use relative imports, and fix comment references. - Copy matcher relevant parts of the `package:test` README into this README.
jakemac53
reviewed
Mar 9, 2023
This had previously been omitted from `package:test/expect.dart` since it is deprecated, but there is no particularly strong reason to force this part of the migration along with the import rewrites.
jakemac53
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_api/frontenddirectory, except for the testrelated to the scaffolding functions.
avoid implicit
dynamicarguments, use relative imports, and fixcomment references.
package:testREADME into thisREADME.