Use fewer empty lists; non-growable #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srawlins
added a commit
to flutter/packages
that referenced
this pull request
Nov 1, 2022
The children list of an Element became unmodifiable in dart-lang/markdown#463, so this just changes flutter_markdown to not modify the children, in a test. Fixes https://github.com/dart-lang/markdown/issues/480
Merged
11 tasks
srawlins
added a commit
to flutter/packages
that referenced
this pull request
Nov 2, 2022
…ction (#2758) Do not modify children of a markdown Element after construction The children list of an Element became unmodifiable in dart-lang/markdown#463, so this just changes flutter_markdown to not modify the children, in a test. Fixes https://github.com/dart-lang/markdown/issues/480
percula
pushed a commit
to percula/packages
that referenced
this pull request
Nov 17, 2022
…ction (flutter#2758) Do not modify children of a markdown Element after construction The children list of an Element became unmodifiable in dart-lang/markdown#463, so this just changes flutter_markdown to not modify the children, in a test. Fixes https://github.com/dart-lang/markdown/issues/480
mosuem
pushed a commit
to dart-lang/tools
that referenced
this pull request
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly this replaces a few
foo ?? []cases with something that does not unnecessarily create a new list. Maybe simpler readability too.