Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusted generalized type alias feature spec to indicate ongoing discussion #88

Merged
merged 6 commits into from
Nov 9, 2018

Conversation

eernstg
Copy link
Member

@eernstg eernstg commented Nov 8, 2018

The feature specification for constructs like typedef F<X> = List<X>; was added a few days ago, but it turns out that we need to discuss one element of the design ("is it allowed to use a type alias as a class?, e.g. class C extends F<int> {}, new F(), where F denotes a type alias").

This CL makes it explicit that that particular decision has not yet been made, and it indicates two likely outcomes of the discussion. This should be sufficient to put readers in a good position to understand what's going on.

munificent and others added 2 commits November 8, 2018 10:03
Support spread elements in const collections.
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@eernstg eernstg merged commit c6d7493 into master Nov 9, 2018
@eernstg eernstg deleted the spec_mark_discussion_nonfun_typedef_nov18 branch November 9, 2018 10:19
@eernstg eernstg restored the spec_mark_discussion_nonfun_typedef_nov18 branch November 29, 2018 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants