feat(ok_http): add user-agent#1831
Conversation
PR HealthBreaking changes ✔️
This check can be disabled by tagging the PR with Changelog Entry ❗
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with
Coverage
|
| File | Coverage |
|---|---|
| pkgs/ok_http/lib/src/ok_http_client.dart | 💔 Not covered |
This check for test coverage is informational (issues shown here will not fail the PR).
This check can be disabled by tagging the PR with skip-coverage-check.
API leaks ⚠️
The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
| Package | Leaked API symbol | Leaking sources |
|---|---|---|
| ok_http | $Certificate$NullableType | jni/bindings.dart::Certificate::nullableType |
| ok_http | $Certificate$Type | jni/bindings.dart::Certificate::type |
| ok_http | PublicKey | jni/bindings.dart::Certificate::verify::publicKey jni/bindings.dart::$PublicKey$NullableType jni/bindings.dart::$PublicKey$NullableType::nullableType jni/bindings.dart::$PublicKey$Type jni/bindings.dart::$PublicKey$Type::nullableType jni/bindings.dart::Certificate::verify$1::publicKey jni/bindings.dart::Certificate::verify$2::publicKey jni/bindings.dart::Certificate::getPublicKey jni/bindings.dart::X509Certificate::verify2::publicKey |
| ok_http | $PublicKey$NullableType | jni/bindings.dart::PublicKey::nullableType |
| ok_http | $PublicKey$Type | jni/bindings.dart::PublicKey::type |
| ok_http | $PublicKey | jni/bindings.dart::PublicKey::implementIn::$impl jni/bindings.dart::PublicKey::implement::$impl |
| ok_http | $X509Certificate$NullableType | jni/bindings.dart::X509Certificate::nullableType |
| ok_http | $X509Certificate$Type | jni/bindings.dart::X509Certificate::type |
| ok_http | $PrivateKey$NullableType | jni/bindings.dart::PrivateKey::nullableType |
| ok_http | $PrivateKey$Type | jni/bindings.dart::PrivateKey::type |
| ok_http | $PrivateKey | jni/bindings.dart::PrivateKey::implementIn::$impl jni/bindings.dart::PrivateKey::implement::$impl |
This check can be disabled by tagging the PR with skip-leaking-check.
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
| Files |
|---|
| no missing headers |
All source files should start with a license header.
Unrelated files missing license headers
| Files |
|---|
| pkgs/http/example/main.dart |
This check can be disabled by tagging the PR with skip-license-check.
| /// This should only be used in a testing environment. | ||
| final bool validateServerCertificates; | ||
|
|
||
| final String? userAgent; |
There was a problem hiding this comment.
Could you add dart doc for this?
|
Without additional information we're not able to resolve this PR. Feel free to add more info or respond to any questions above. Thanks for your contribution! |
This adds an
userAgentconfiguration field as with other HTTP libraries. This allows more flexibility in migrating from dart:io's HTTP to OkHttp.