-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a bug where Dart callback arguments were sometimes corrupted #1448
Conversation
PR Health
Breaking changes
|
Package | Change | Current Version | New Version | Needed Version | Looking good? |
---|---|---|---|---|---|
cupertino_http | Breaking | 2.0.1 | 2.0.2-wip | 3.0.0 Got "2.0.2-wip" expected >= "3.0.0" (breaking changes) |
This check can be disabled by tagging the PR with skip-breaking-check
.
Changelog Entry ✔️
Package | Changed Files |
---|
Changes to files need to be accounted for in their respective changelogs.
Coverage ⚠️
File | Coverage |
---|---|
pkgs/cupertino_http/lib/src/native_cupertino_bindings.dart | 💔 Not covered |
This check for test coverage is informational (issues shown here will not fail the PR).
This check can be disabled by tagging the PR with skip-coverage-check
.
API leaks ⚠️
The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
Package | Leaked API symbols |
---|---|
cupertino_http | ncb.NSURLCache NSURLRequest NSURLRequestAttribution _NSZone NSCachedURLResponse ncb.NSURLSessionConfiguration SSLProtocol tls_protocol_version_t NSHTTPCookieStorage NSURLCredentialStorage __darwin_mcontext64 _opaque_pthread_attr_t __darwin_sigaltstack __darwin_ucontext __siginfo sigval rusage_info_v6 _malloc_zone_t _opaque_pthread_cond_t _opaque_pthread_condattr_t _opaque_pthread_mutex_t _opaque_pthread_mutexattr_t _opaque_pthread_once_t _opaque_pthread_rwlock_t _opaque_pthread_rwlockattr_t _opaque_pthread_t UnsignedWide ProcessSerialNumber Point Rect wide TimeBaseRecord NumVersionVariant NumVersion VersRec Float80 Float96 __CFString __CFNull __CFAllocator __CFArray __SecCertificate __SecIdentity __SecKey __SecPolicy __SecAccessControl __SecKeychain __SecKeychainItem __SecKeychainSearch SecKeychainAttribute __SecTrustedApplication __SecAccess __SecACL __SecPassword __sFILE __CFBag __CFBinaryHeap __CFBitVector __CFDictionary __CFNotificationCenter __CFLocale __CFDate __CFTimeZone __CFData __CFCharacterSet __CFError __CFCalendar __CFDateFormatter __CFBoolean __CFNumber __CFNumberFormatter __CFURL mach_port_status mach_port_limits mach_port_info_ext mach_port_guard_info mach_port_qos mach_service_port_info mach_port_options UnnamedUnion1 __CFRunLoop __CFRunLoopSource __CFRunLoopObserver __CFRunLoopTimer __CFSocket fsignatures fsupplement fchecklv fgetsigsinfo fstore fpunchhole ftrimactivefile fspecread fattributiontag _filesec OS_os_workgroup os_workgroup_attr_opaque_s os_workgroup_join_token_opaque_s os_workgroup_max_parallel_threads_attr_s os_workgroup_interval_data_opaque_s time_value mach_timespec mach_msg_mac_trailer_t security_token_t audit_token_t msg_labels_t mach_msg_security_trailer_t dispatch_source_type_s __CFReadStream __CFWriteStream __CFSet __CFTree __CFUUID __CFBundle __CFMessagePort __CFPlugInInstance __CFMachPort __CFAttributedString __CFURLEnumerator kauth_ace guid_t kauth_acl kauth_filesec _acl _acl_entry _acl_permset _acl_flagset __CFFileSecurity __CFStringTokenizer __CFFileDescriptor __CFUserNotification __CFXMLNode __CFXMLParser cssm_data SecAsn1Template_struct cssm_guid cssm_version cssm_subservice_uid cssm_net_address cssm_crypto_data cssm_list_element UnnamedUnion2 cssm_list CSSM_TUPLE cssm_tuplegroup cssm_sample cssm_samplegroup cssm_memory_funcs cssm_encoded_cert cssm_parsed_cert cssm_cert_pair cssm_certgroup UnnamedUnion3 cssm_base_certs cssm_access_credentials cssm_authorizationgroup cssm_acl_validity_period cssm_acl_entry_prototype cssm_acl_owner_prototype cssm_acl_entry_input cssm_resource_control_context cssm_acl_entry_info cssm_acl_edit cssm_func_name_addr cssm_date cssm_range cssm_query_size_data cssm_key_size cssm_keyheader cssm_key cssm_dl_db_handle cssm_context_attribute cssm_context_attribute_value cssm_kr_profile cssm_context cssm_pkcs1_oaep_params cssm_csp_operational_statistics cssm_pkcs5_pbkdf1_params cssm_pkcs5_pbkdf2_params cssm_kea_derive_params cssm_tp_authority_id cssm_field cssm_tp_policyinfo cssm_dl_db_list cssm_tp_callerauth_context cssm_encoded_crl cssm_parsed_crl cssm_crl_pair cssm_crlgroup UnnamedUnion4 cssm_fieldgroup cssm_evidence cssm_tp_verify_context cssm_tp_verify_context_result cssm_tp_request_set cssm_tp_result_set cssm_tp_confirm_response cssm_tp_certissue_input cssm_tp_certissue_output cssm_tp_certchange_input cssm_tp_certchange_output cssm_tp_certverify_input cssm_tp_certverify_output cssm_tp_certnotarize_input cssm_tp_certnotarize_output cssm_tp_certreclaim_input cssm_tp_certreclaim_output cssm_tp_crlissue_input cssm_tp_crlissue_output cssm_cert_bundle_header cssm_cert_bundle cssm_db_attribute_info cssm_db_attribute_label cssm_db_attribute_data cssm_db_record_attribute_info cssm_db_record_attribute_data cssm_db_parsing_module_info cssm_db_index_info cssm_db_unique_record cssm_db_record_index_info cssm_dbinfo cssm_selection_predicate cssm_query_limits cssm_query cssm_dl_pkcs11_attributes cssm_name_list cssm_db_schema_attribute_info cssm_db_schema_index_info SecAsn1AlgId cssm_x509_type_value_pair cssm_x509_rdn cssm_x509_name SecAsn1PubKeyInfo cssm_x509_time x509_validity cssm_x509ext_basicConstraints cssm_x509_extensionTagAndValue cssm_x509ext_pair cssm_x509_extension cssm_x509ext_value extension_data_format cssm_x509_extensions cssm_x509_tbs_certificate cssm_x509_signature cssm_x509_signed_certificate cssm_x509ext_policyQualifierInfo cssm_x509ext_policyQualifiers cssm_x509ext_policyInfo cssm_x509_revoked_cert_entry cssm_x509_revoked_cert_list cssm_x509_tbs_certlist cssm_x509_signed_crl __CE_OtherName __CE_GeneralName __CE_GeneralNameType __CE_GeneralNames __CE_AuthorityKeyID __CE_ExtendedKeyUsage __CE_BasicConstraints __CE_PolicyQualifierInfo __CE_PolicyInformation __CE_CertPolicies __CE_DistributionPointName UnnamedUnion5 __CE_CrlDistributionPointNameType __CE_CRLDistributionPoint __CE_CRLDistPointsSyntax __CE_AccessDescription __CE_AuthorityInfoAccess __CE_SemanticsInformation __CE_QC_Statement __CE_QC_Statements __CE_IssuingDistributionPoint __CE_GeneralSubtree __CE_GeneralSubtrees __CE_NameConstraints __CE_PolicyMapping __CE_PolicyMappings __CE_PolicyConstraints __CE_DataAndType CE_Data __CE_DataType cssm_acl_process_subject_selector cssm_acl_keychain_prompt_selector cssm_appledl_open_parameters cssm_applecspdl_db_settings_parameters cssm_applecspdl_db_is_locked_parameters cssm_applecspdl_db_change_password_parameters __SecTrust SSLContext |
This check can be disabled by tagging the PR with skip-leaking-check
.
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files |
---|
no missing headers |
All source files should start with a license header.
Unrelated files missing license headers
Files |
---|
pkgs/http/example/main.dart |
pkgs/http_client_conformance_tests/example/client_test.dart |
pkgs/http_client_conformance_tests/lib/src/dummy_isolate.dart |
pkgs/http_parser/test/example_test.dart |
pkgs/http_profile/lib/http_profile.dart |
pkgs/web_socket/example/web_socket_example.dart |
pkgs/web_socket/lib/testing.dart |
pkgs/web_socket_conformance_tests/example/client_test.dart |
Revisions updated by `dart tools/rev_sdk_deps.dart`. core (https://github.com/dart-lang/core/compare/7a71ad6..72a2060): 72a20603 2025-01-17 Nate Bosch Remove sorting of allowedHelp maps (dart-lang/core#852) a59cbeaf 2025-01-13 Kevin Moore [os_detect] move to pkg:web, prepare publish (dart-lang/core#850) 48c3c458 2025-01-13 Kevin Moore [path] fix tests to compile/run with wasm (dart-lang/core#851) 2ac228bd 2025-01-09 Devon Carew update lint issue templates (dart-lang/core#849) 513fa2f0 2025-01-08 Devon Carew fix a line break issue in the package table (dart-lang/core#846) eb74f032 2025-01-06 Devon Carew Update package:collection for the new `strict_top_level_inference` lint (dart-lang/core#735) ecosystem (https://github.com/dart-lang/ecosystem/compare/efe4ee4..682c8ef): 682c8ef 2025-01-17 Moritz Update `dart_apitool` version in health workflow. (dart-lang/ecosystem#338) 94b4cea 2025-01-14 Kevin Moore [puppy] actually rename command to `run`, sort directories, better logs (dart-lang/ecosystem#337) f2d3178 2025-01-10 Devon Carew rename the 'map' command to 'run' (dart-lang/ecosystem#336) 25c57b8 2025-01-10 Kevin Moore [puppy] Introduce a package for misc Dart CLI tools (dart-lang/ecosystem#335) 21e81c5 2025-01-08 Kevin Moore [corpus] update to latest analyzer, bump min SDK (dart-lang/ecosystem#334) http (https://github.com/dart-lang/http/compare/6ecd13a..27184eb): 27184eb 2025-01-21 Brian Quinlan Remove bespoke code that handled blocking callbacks (dart-lang/http#1450) 7271367 2025-01-20 Kevin Moore [http] prepare v1.3.0 release (dart-lang/http#1451) 7f50fc5 2025-01-15 Brian Quinlan Prepare cupertino_http 2.0.2 for release (dart-lang/http#1449) 2bc4cc9 2025-01-15 Brian Quinlan Fix incorrect response processing (dart-lang/http#1448) 531d3e5 2025-01-09 Kevin Moore [http2, conformance_tests] update dependencies (dart-lang/http#1443) f0bcf02 2025-01-06 Brian Quinlan Add tests to verify NUL, CR & LF header value behavior (dart-lang/http#1440) test (https://github.com/dart-lang/test/compare/f364fc8..7fc9521): 7fc95218 2025-01-17 Nate Bosch Drop reference to legacy communication protocol (dart-lang/test#2446) 073ef8bd 2025-01-17 Matan Lurey Fix a type error that occurs comparing two large maps with `deepEquals`. (dart-lang/test#2442) b5bfba54 2025-01-17 Nate Bosch Unblock CI: Ignore deprecation and skip a test (dart-lang/test#2445) web (https://github.com/dart-lang/web/compare/af5de5e..fd3d988): fd3d988 2025-01-14 KennethHung Adapt paths for different development environments (dart-lang/web#336) 7f440e4 2025-01-10 KennethHung Remove renames where the type doesn't exist anymore (dart-lang/web#334) 3b06da9 2025-01-09 KennethHung Add missing FileReader event getters (dart-lang/web#333) webdev (https://github.com/dart-lang/webdev/compare/e72f365..4a92ba5): 4a92ba58 2025-01-13 Ben Konyi [ DWDS ] Reset version to 24.3.3-wip (dart-lang/webdev#2569) cc5aff69 2025-01-10 Ben Konyi [ DWDS ] Relax DDS constraint, prepare for 24.3.2 release 562ab622 2025-01-10 Ben Konyi [ DWDS ] Reset version to 24.3.2-wip a7c8fe76 2025-01-10 Ben Konyi Allow for setting custom DDS port (dart-lang/webdev#2546) 7dc5c3a9 2025-01-09 Ben Konyi Rename copied SDK directory prefix from 'sdk copy' to 'sdk_copy' (dart-lang/webdev#2557) 659e1dfc 2025-01-08 Jessy Yameogo Added support for some debugging APIs with the DDC library bundle format - part 5 (dart-lang/webdev#2549) fcd906fc 2025-01-07 Srujan Gaddam Add ignores for deprecated web libraries with a TODO and move dwds to 24.4.0-wip (dart-lang/webdev#2559) Change-Id: I3e847d24146bfb6891e77098591b785a0d15a445 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/405243 Auto-Submit: Devon Carew <[email protected]> Reviewed-by: Konstantin Shcheglov <[email protected]> Commit-Queue: Konstantin Shcheglov <[email protected]>
This reverts commit a1e5451. Reason for revert: it looks like golem is broken Original change's description: > [deps] rev core, ecosystem, http, test, web, webdev > > Revisions updated by `dart tools/rev_sdk_deps.dart`. > > core (https://github.com/dart-lang/core/compare/7a71ad6..72a2060): > 72a20603 2025-01-17 Nate Bosch Remove sorting of allowedHelp maps (dart-lang/core#852) > a59cbeaf 2025-01-13 Kevin Moore [os_detect] move to pkg:web, prepare publish (dart-lang/core#850) > 48c3c458 2025-01-13 Kevin Moore [path] fix tests to compile/run with wasm (dart-lang/core#851) > 2ac228bd 2025-01-09 Devon Carew update lint issue templates (dart-lang/core#849) > 513fa2f0 2025-01-08 Devon Carew fix a line break issue in the package table (dart-lang/core#846) > eb74f032 2025-01-06 Devon Carew Update package:collection for the new `strict_top_level_inference` lint (dart-lang/core#735) > > ecosystem (https://github.com/dart-lang/ecosystem/compare/efe4ee4..682c8ef): > 682c8ef 2025-01-17 Moritz Update `dart_apitool` version in health workflow. (dart-lang/ecosystem#338) > 94b4cea 2025-01-14 Kevin Moore [puppy] actually rename command to `run`, sort directories, better logs (dart-lang/ecosystem#337) > f2d3178 2025-01-10 Devon Carew rename the 'map' command to 'run' (dart-lang/ecosystem#336) > 25c57b8 2025-01-10 Kevin Moore [puppy] Introduce a package for misc Dart CLI tools (dart-lang/ecosystem#335) > 21e81c5 2025-01-08 Kevin Moore [corpus] update to latest analyzer, bump min SDK (dart-lang/ecosystem#334) > > http (https://github.com/dart-lang/http/compare/6ecd13a..27184eb): > 27184eb 2025-01-21 Brian Quinlan Remove bespoke code that handled blocking callbacks (dart-lang/http#1450) > 7271367 2025-01-20 Kevin Moore [http] prepare v1.3.0 release (dart-lang/http#1451) > 7f50fc5 2025-01-15 Brian Quinlan Prepare cupertino_http 2.0.2 for release (dart-lang/http#1449) > 2bc4cc9 2025-01-15 Brian Quinlan Fix incorrect response processing (dart-lang/http#1448) > 531d3e5 2025-01-09 Kevin Moore [http2, conformance_tests] update dependencies (dart-lang/http#1443) > f0bcf02 2025-01-06 Brian Quinlan Add tests to verify NUL, CR & LF header value behavior (dart-lang/http#1440) > > test (https://github.com/dart-lang/test/compare/f364fc8..7fc9521): > 7fc95218 2025-01-17 Nate Bosch Drop reference to legacy communication protocol (dart-lang/test#2446) > 073ef8bd 2025-01-17 Matan Lurey Fix a type error that occurs comparing two large maps with `deepEquals`. (dart-lang/test#2442) > b5bfba54 2025-01-17 Nate Bosch Unblock CI: Ignore deprecation and skip a test (dart-lang/test#2445) > > web (https://github.com/dart-lang/web/compare/af5de5e..fd3d988): > fd3d988 2025-01-14 KennethHung Adapt paths for different development environments (dart-lang/web#336) > 7f440e4 2025-01-10 KennethHung Remove renames where the type doesn't exist anymore (dart-lang/web#334) > 3b06da9 2025-01-09 KennethHung Add missing FileReader event getters (dart-lang/web#333) > > webdev (https://github.com/dart-lang/webdev/compare/e72f365..4a92ba5): > 4a92ba58 2025-01-13 Ben Konyi [ DWDS ] Reset version to 24.3.3-wip (dart-lang/webdev#2569) > cc5aff69 2025-01-10 Ben Konyi [ DWDS ] Relax DDS constraint, prepare for 24.3.2 release > 562ab622 2025-01-10 Ben Konyi [ DWDS ] Reset version to 24.3.2-wip > a7c8fe76 2025-01-10 Ben Konyi Allow for setting custom DDS port (dart-lang/webdev#2546) > 7dc5c3a9 2025-01-09 Ben Konyi Rename copied SDK directory prefix from 'sdk copy' to 'sdk_copy' (dart-lang/webdev#2557) > 659e1dfc 2025-01-08 Jessy Yameogo Added support for some debugging APIs with the DDC library bundle format - part 5 (dart-lang/webdev#2549) > fcd906fc 2025-01-07 Srujan Gaddam Add ignores for deprecated web libraries with a TODO and move dwds to 24.4.0-wip (dart-lang/webdev#2559) > > Change-Id: I3e847d24146bfb6891e77098591b785a0d15a445 > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/405243 > Auto-Submit: Devon Carew <[email protected]> > Reviewed-by: Konstantin Shcheglov <[email protected]> > Commit-Queue: Konstantin Shcheglov <[email protected]> Change-Id: I27c20ef89095a7d602c1a609d5533a27a7683a47 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/405445 Commit-Queue: Konstantin Shcheglov <[email protected]> Auto-Submit: Devon Carew <[email protected]> Reviewed-by: Konstantin Shcheglov <[email protected]> Bot-Commit: Rubber Stamper <[email protected]>
Updates to
ffigen
16.1 to capture this change: dart-lang/native#1888Fixes #1413
Fixes #1446
Contribution guidelines:
dart format
.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.