Skip to content

Fix -WIP ending detection #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mosuem merged 2 commits into from
Jul 10, 2026
Merged

Fix -WIP ending detection #430

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a113cf
Fix `-WIP` ending detection
mosuem Jul 10, 2026
ac8b967
suggestion
mosuem Jul 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkgs/firehose/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
- Improve and clarify readme documentation.
- Add description for the table 'Package publishing'.
- Simplify `groundskeeper` workflow
- Fix recognition of `-wip` endings.

## 0.13.1

Expand Down
11 changes: 9 additions & 2 deletions pkgs/firehose/lib/src/pub.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,13 @@ class Pub {
}

extension VersionExtension on Version {
bool get wip =>
isPreRelease && preRelease.length == 1 && preRelease.first == 'wip';
bool get wip {
if (!isPreRelease) return false;
final last = preRelease.last;
if (last is String) {
return last == 'wip' || // e.g. 1.2.3-wip
last.endsWith('-wip'); // e.g. 1.2.3-alpha.3-wip
}
return false;
}
Comment thread
mosuem marked this conversation as resolved.
}
15 changes: 15 additions & 0 deletions pkgs/firehose/test/pub_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,5 +63,20 @@ void main() {
final version = Version.parse('1.2.3-wip');
expect(version.wip, true);
});

test('wip pre-release multipart wip (dot)', () async {
final version = Version.parse('1.2.3-alpha.3.wip');
expect(version.wip, true);
});

test('wip pre-release multipart wip (hyphen)', () async {
final version = Version.parse('1.2.3-alpha.3-wip');
expect(version.wip, true);
});

test('wip pre-release awip', () async {
final version = Version.parse('1.2.3-awip');
expect(version.wip, false);
});
});
}
Loading