Skip to content

Run pub get before dart format in groundskeeper #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mosuem merged 2 commits into from
Jul 8, 2026
Merged

Run pub get before dart format in groundskeeper #429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3b9a86
Run pub get before dart format in groundskeeper
mosuem Jul 8, 2026
d53ee44
Remove line
mosuem Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkgs/firehose/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
## 0.13.2-wip

- Run `pub get` before `dart format` in `groundskeeper`.
- Add `groundskeeper` executable to format and fix packages.
- Add parameter to `locatePackages` to allow locating all packages with `publish_to: none`.
- Inlined GitHub comment management into `firehose` as a first-class executable.
Expand Down
32 changes: 17 additions & 15 deletions pkgs/firehose/bin/groundskeeper.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ void main(List<String> args) async {
final argResults = parser.parse(args);

final targetDirectory = Directory.current;
final pkgPath = targetDirectory.path;
final runFormat = argResults['format'] != 'false';
final runFix = argResults['fix'] != 'false';

Expand All @@ -31,23 +32,9 @@ Error: Run fix is enabled, but no pubspec.yaml found in ${targetDirectory.path}'
exit(1);
}

if (runFormat) {
print('Running dart format...');
final result = await Process.run(
'dart',
['format', targetDirectory.path],
);
stdout.write(result.stdout);
stderr.write(result.stderr);
if (result.exitCode != 0) {
exit(result.exitCode);
}
}

if (runFix) {
if (isPackage) {
Comment thread
mosuem marked this conversation as resolved.
final repo = Repository(targetDirectory);
final pkg = Package(targetDirectory, repo);
final pkgPath = targetDirectory.path;

// Detect if it is a Flutter package
final isFlutter = pkg.pubspec.dependencies.containsKey('flutter') ||
Expand All @@ -65,7 +52,22 @@ Error: Run fix is enabled, but no pubspec.yaml found in ${targetDirectory.path}'
print('Error: $tool pub get failed in $pkgPath');
exit(pubGetResult.exitCode);
}
}

if (runFormat) {
print('Running dart format...');
final result = await Process.run(
'dart',
['format', pkgPath],
);
stdout.write(result.stdout);
stderr.write(result.stderr);
if (result.exitCode != 0) {
exit(result.exitCode);
}
}

if (runFix) {
print(' Running dart fix --apply...');
final fixResult = await Process.run('dart', ['fix', '--apply'],
workingDirectory: pkgPath);
Expand Down
Loading