Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cli mode #313

Draft
wants to merge 25 commits into
base: main
Choose a base branch
from
Draft

Add cli mode #313

wants to merge 25 commits into from

Conversation

mosuem
Copy link
Member

@mosuem mosuem commented Oct 28, 2024

  • Thanks for your contribution! Please replace this text with a description of what this PR is changing or adding and why, list any relevant issues, and review the contribution guidelines below.

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@github-actions github-actions bot added package:firehose type-infra A repository infrastructure change or enhancement labels Oct 28, 2024
Copy link

Package publishing

Package Version Status Publish tag (post-merge)
package:firehose 0.10.0 ready to publish firehose-v0.10.0
package:dart_flutter_team_lints 3.2.1 already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

Copy link

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
dart_flutter_team_lints None 3.2.1 3.2.1 3.2.1 ✔️
firehose Breaking 0.9.3 0.10.0 0.10.0 ✔️
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ⚠️
File Coverage
pkgs/dart_flutter_team_lints/tool/dedup.dart 💔 Not covered
pkgs/firehose/bin/firehose.dart 💔 Not covered
pkgs/firehose/bin/health.dart 💚 16 %
pkgs/firehose/lib/firehose.dart 💔 0 % ⬇️ NaN %
pkgs/firehose/lib/src/changelog.dart 💚 100 %
pkgs/firehose/lib/src/delayed_client.dart 💚 23 %
pkgs/firehose/lib/src/github.dart 💚 68 %
pkgs/firehose/lib/src/health/changelog.dart 💚 97 %
pkgs/firehose/lib/src/health/coverage.dart 💔 76 % ⬇️ 1 %
pkgs/firehose/lib/src/health/health.dart 💔 82 % ⬇️ 13 %
pkgs/firehose/lib/src/health/lcov.dart 💚 89 %
pkgs/firehose/lib/src/health/license.dart 💚 100 %
pkgs/firehose/lib/src/pub.dart 💚 89 %
pkgs/firehose/lib/src/repo.dart 💔 91 % ⬇️ 2 %
pkgs/firehose/lib/src/utils.dart 💚 24 %
pkgs/firehose/test_data/base_test_repo/pkgs/package1/bin/package1.dart 💔 Not covered
pkgs/firehose/test_data/base_test_repo/pkgs/package1/lib/package1.dart 💔 Not covered
pkgs/firehose/test_data/base_test_repo/pkgs/package1/test/package1_test.dart 💔 Not covered
pkgs/firehose/test_data/base_test_repo/pkgs/package2/bin/package2.dart 💔 Not covered
pkgs/firehose/test_data/base_test_repo/pkgs/package2/lib/package2.dart 💔 Not covered
pkgs/firehose/test_data/base_test_repo/pkgs/package2/test/package2_test.dart 💔 Not covered
pkgs/firehose/test_data/base_test_repo/pkgs/package3/bin/package3.dart 💔 Not covered
pkgs/firehose/test_data/base_test_repo/pkgs/package3/lib/package3.dart 💔 Not covered
pkgs/firehose/test_data/base_test_repo/pkgs/package3/test/package3_test.dart 💔 Not covered
pkgs/firehose/test_data/base_test_repo/pkgs/package5/lib/package5.dart 💔 Not covered
pkgs/firehose/test_data/base_test_repo/pkgs/package5/lib/src/package5_base.dart 💔 Not covered
pkgs/firehose/test_data/test_repo/pkgs/package1/bin/package1.dart 💔 Not covered
pkgs/firehose/test_data/test_repo/pkgs/package1/lib/package1.dart 💔 Not covered
pkgs/firehose/test_data/test_repo/pkgs/package1/test/package1_test.dart 💔 Not covered
pkgs/firehose/test_data/test_repo/pkgs/package2/bin/package2.dart 💔 Not covered
pkgs/firehose/test_data/test_repo/pkgs/package2/lib/anotherLib.dart 💔 Not covered
pkgs/firehose/test_data/test_repo/pkgs/package2/lib/package2.dart 💔 Not covered
pkgs/firehose/test_data/test_repo/pkgs/package2/test/package2_test.dart 💔 Not covered
pkgs/firehose/test_data/test_repo/pkgs/package3/bin/package3.dart 💔 Not covered
pkgs/firehose/test_data/test_repo/pkgs/package3/lib/package3.dart 💔 Not covered
pkgs/firehose/test_data/test_repo/pkgs/package3/test/package3_test.dart 💔 Not covered
pkgs/firehose/test_data/test_repo/pkgs/package5/lib/package5.dart 💔 Not covered
pkgs/firehose/test_data/test_repo/pkgs/package5/lib/src/package5_base.dart 💔 Not covered

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

Do Not Submit

Body contains DO_NOT_SUBMIT: false

Files with DO_NOT_SUBMIT
pkgs/firehose/test_data/golden/comment_do-not-submit.md
pkgs/firehose/test_data/golden/comment_do-not-submit_healthchanged.md
pkgs/firehose/test_data/test_repo/pkgs/package1/bin/package1.dart
pkgs/firehose/README.md

This check can be disabled by tagging the PR with skip-do-not-submit-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:firehose type-infra A repository infrastructure change or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant