Support optional new and const.
#652
Labels
Milestone
Comments
7 tasks
munificent
added a commit
that referenced
this issue
Feb 20, 2018
In almost all cases, an elided "new"/"const" is parsed as a normal method call by analyzer, so the existing formatting behavior for those does the right thing. The only edge case is a named constructor on a generic class. That syntax can *only* be a constructor call, so it's parsed as an instance creation expression. When we get to that code path, we need to not add an extra space before the class name if there is no preceding "new" or "const" keyword. Fix #652.
munificent
added a commit
that referenced
this issue
Feb 20, 2018
In almost all cases, an elided "new"/"const" is parsed as a normal method call by analyzer, so the existing formatting behavior for those does the right thing. The only edge case is a named constructor on a generic class. That syntax can *only* be a constructor call, so it's parsed as an instance creation expression. When we get to that code path, we need to not add an extra space before the class name if there is no preceding "new" or "const" keyword. Fix #652.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is the formatter specific issue tracking dart-lang/sdk#30921.
The formatter for Dart 2 will need to understand and format programs that omit some
newandconstprefixes.The exact details depends on which format the common front-end provides for such a program, but it must be possible to format without introducing the missing
newandconsttokens in the output.The text was updated successfully, but these errors were encountered: