-
Notifications
You must be signed in to change notification settings - Fork 221
Improve package:build API docs.
#4205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
06f2c13 to
0ec999d
Compare
PR HealthChangelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with |
0ec999d to
e772432
Compare
e772432 to
916a6ba
Compare
jensjoha
approved these changes
Sep 10, 2025
davidmorgan
commented
Sep 10, 2025
Contributor
Author
davidmorgan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non-doc changes
AssetId.parsesince the main constructor allows them, add test coverage showing it allows themchangeExtensionso I am sure I documented it correctly :)asset_id.dart:id_test.dart->asset_id_test.dartDoc / readability improvements
AssetReaderandAssetWriternext toBuildStepand the docs onBuildStepsince that's the class builders interact with directlyBuilderFactoryandBuildConfigI didn't get to all the API yet, more to come later :)