Skip to content

Remove unused bool. #4171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidmorgan merged 1 commit into from
Sep 1, 2025
Merged

Remove unused bool. #4171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 2 additions & 18 deletions build_runner_core/lib/src/generate/build_definition.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,22 +29,14 @@ class BuildDefinition {
final AssetGraph assetGraph;
final BuildScriptUpdates? buildScriptUpdates;

/// Whether this is a build starting from no previous state or outputs.
final bool cleanBuild;

/// When reusing serialized state from a previous build: the file updates
/// since that build.
///
/// Or, `null` if there was no serialized state or it was discared due to
/// the current build having an incompatible change.
final Map<AssetId, ChangeType>? updates;

BuildDefinition._(
this.assetGraph,
this.buildScriptUpdates,
this.cleanBuild,
this.updates,
);
BuildDefinition._(this.assetGraph, this.buildScriptUpdates, this.updates);

static Future<BuildDefinition> prepareWorkspace({
required PackageGraph packageGraph,
Expand Down Expand Up @@ -100,9 +92,7 @@ class _Loader {

BuildScriptUpdates? buildScriptUpdates;
Map<AssetId, ChangeType>? updates;
var cleanBuild = true;
if (assetGraph != null) {
cleanBuild = false;
buildLog.doing('Checking for updates.');
updates = await _computeUpdates(
assetGraph,
Expand Down Expand Up @@ -138,7 +128,6 @@ class _Loader {
assetGraph = null;
buildScriptUpdates = null;
updates = null;
cleanBuild = true;
}
}

Expand Down Expand Up @@ -192,12 +181,7 @@ class _Loader {
await _initialBuildCleanup(conflictingOutputs, writer);
}

return BuildDefinition._(
assetGraph,
buildScriptUpdates,
cleanBuild,
updates,
);
return BuildDefinition._(assetGraph, buildScriptUpdates, updates);
}

/// Deletes the generated output directory.
Expand Down
5 changes: 0 additions & 5 deletions build_runner_core/lib/src/generate/build_series.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,6 @@ class BuildSeries {
/// if the serialized build state was discarded.
Map<AssetId, ChangeType>? updatesFromLoad;

/// Whether this is or was a build starting from no previous state or outputs.
final bool cleanBuild;

/// Whether the next build is the first build.
bool firstBuild = true;

Expand All @@ -64,7 +61,6 @@ class BuildSeries {
this.assetGraph,
this.buildScriptUpdates,
this.finalizedReader,
this.cleanBuild,
this.updatesFromLoad,
) : readerWriter = buildPlan.reader.copyWith(
generatedAssetHider: assetGraph,
Expand Down Expand Up @@ -149,7 +145,6 @@ class BuildSeries {
buildDefinition.assetGraph,
buildDefinition.buildScriptUpdates,
finalizedReader,
buildDefinition.cleanBuild,
buildDefinition.updates,
);
return build;
Expand Down
Loading