This repository has been archived by the owner on Aug 30, 2023. It is now read-only.
Fix bug in numberOfIntegerDigits calculation, simplifying the algorithm
#535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devoncarew
approved these changes
Jan 20, 2023
| return max(1, (log(simpleNumber) / _ln10).ceil()); | ||
| if (simpleNumber < 100000000000000000) return 17; | ||
| if (simpleNumber < 1000000000000000000) return 18; | ||
| return 19; |
There was a problem hiding this comment.
I assume we're not expecting anything past 19?
There was a problem hiding this comment.
Anything larger cannot be represented in 64 bits, so we are safe!
| @@ -0,0 +1,12 @@ | |||
| import 'package:intl/intl.dart'; | |||
There was a problem hiding this comment.
nit: add a copyright header for this file
patel-aum
approved these changes
Jan 22, 2023
devoncarew
approved these changes
Jan 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where the number of digits may be wrong due to rounding errors.