This repository was archived by the owner on Aug 30, 2023. It is now read-only.
Fix doc comments for DateFormat.#156
Closed
srawlins wants to merge 1 commit into
Closed
Conversation
alan-knight
suggested changes
Jan 31, 2018
alan-knight
left a comment
alan-knight
left a comment
Contributor
There was a problem hiding this comment.
Merged by jumping through hoops backwards.
alan-knight
added a commit
that referenced
this pull request
Mar 20, 2018
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=184078340
Contributor
|
This was merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doc comments are broken in some places, like the code snippets here. Doc comments also don't feature the one-sentence first paragraph recommendation that helps with dartdocs.org readability. This PR addresses most of these issues for the DateFormat class.