Support for Inline Array in Struct #206
Conversation
| final struct1 = bindings.getStruct1(); | ||
| var expectedValue = 1; | ||
| for (var i = 0; i < struct1.ref.data.dimensions[0]; i++) { |
There was a problem hiding this comment.
Ah the old api gave access to .dimensions? Then this is kind of a breaking change.
But we should likely add that kind of access to Array in dart:ffi as well.
There was a problem hiding this comment.
Then this is kind of a breaking change
Should I update the version to 3.0.0-beta.1 then?
But we should likely add that kind of access to Array in dart:ffi as well.
Yeah, I was wondering that there's no way to get the length of an array. (even though its constant and the user would know it beforehand)
There was a problem hiding this comment.
Hm, if we want to be true to semantic versioning, we probably should make it 3.0.0-beta.0, good catch!
There was a problem hiding this comment.
Also, the key is probably rejected in the config right now, instead of just deprecated. So that is also a breaking change.
There was a problem hiding this comment.
the key is probably rejected
It will simply warn about an unknown key called array-workaound, the tool would still work since an unknown key is not a severe error.
Updated version.
There was a problem hiding this comment.
I've also removed the previously deprecated llvm-lib config.
Closes dart-lang/native#542
array-workaroundconfig key. (Using this will emit a warning ->unknown key in config).