This repository has been archived by the owner on Dec 19, 2017. It is now read-only.
Fix for core-dropdown "Cannot read property 'position' of null" #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This brings a fix to googlearchive/core-dropdown#11
dylanPowers
changed the title
|
We usually wait until they at least get merged upstream, otherwise we can be left in a weird state if they decide not to merge it for some reason. As soon as that is merged we can merge it here though, if you ping this again once its ready we can merge it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was impacted by the bug reported at googlearchive/core-dropdown#11. Someone graciously created a quick fix at googlearchive/core-dropdown#14, but it has yet to be merged (don't know why). After some quick testing it works great. I don't know if you'd rather that be merged first and ignore this request, but either way it needs to be merged in somewhere as this was giving my app troubles.