Skip to content
This repository has been archived by the owner on Jul 17, 2020. It is now read-only.

Add Irish translation and tests #298

Merged
54 commits merged into from
Mar 11, 2020
Merged

Add Irish translation and tests #298

54 commits merged into from
Mar 11, 2020

Conversation

angeidheal
Copy link
Contributor

No description provided.

@angeidheal
Copy link
Contributor Author

I'm a bit puzzled why this is failing. The log says that it is expecting "Dé Céadaoin seo chugainn" for "next Wednesday" but it is getting "Céadaoin seo chugainn" instead. I've double checked both the language file and the test file and I have "Dé Céadaoin seo chugainn" in both.

@ghost
Copy link

ghost commented Mar 10, 2020

I see the join_with_shared_prefix() function in your translation. Is this appropriate?

(It's intended purpose, in English, is to make "next Wednesday and next Thursday" turn into "next Wednesday and Thursday", or something like that. It might not be appropriate to every language.)

@angeidheal
Copy link
Contributor Author

Thanks again for your help @ironwallaby!

@ghost
Copy link

ghost commented Mar 11, 2020

Thank you! This looks good, I'll get it merged in.

@ghost ghost closed this Mar 11, 2020
@ghost ghost reopened this Mar 11, 2020
@ghost ghost merged commit 9ccbece into darkskyapp:master Mar 11, 2020
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant