This repository has been archived by the owner on Jul 17, 2020. It is now read-only.
Fix some minor issues in the English translations #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-assigned this
ghost
requested review from
nonrenewable-zz,
bpblanken,
hhansson,
jareyes and
mathcolo
nonrenewable-zz
approved these changes
Jan 14, 2020
| @@ -260,9 +263,11 @@ | |||
| ["starting-in", "very-light-rain", ["less-than", ["minutes", 1]]]], | |||
|
|
|||
| "Next hour forecasts are temporarily unavailable due to all nearby radar stations being offline.": | |||
| ["sentence",["next-hour-forecast-status", "temporarily-unavailable", "station-offline"]], | |||
| ["sentence", ["next-hour-forecast-status", "temporarily-unavailable", "station-offline"]], | |||
There was a problem hiding this comment.
we should make the linter yell about these since otherwise i'll keep doing it 😞
There was a problem hiding this comment.
The linter doesn't check JSON :(
midori:translations jay$ ./node_modules/.bin/eslint test_cases/en.json
/Users/jay/Projects/Dark Sky/translations/test_cases/en.json
2:10 error Parsing error: Unexpected token :
✖ 1 problem (1 error, 0 warnings)
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR accomplishes the following:
String#startsWithandString#endsWithandString#includesexist now. It's a lot cleaner to use them, so we do so.parentheticals to be generated with a generic or rain or sleet type. We are working to reduce the number of cases that this can possibly occur for, but in the meantime we should fix the translation to not be confusing. So: we add a test for this, and clarify that the parenthetical refers to a chance of snow accumulation in those cases. I also updated the README to note this.