Test rewrite improvements#2
Merged
darkowlzz merged 2 commits intodarkowlzz:testenv-refactorfrom Nov 11, 2021
Merged
Conversation
This is just a cosmetic thing -- there's no need for the higher-order func used to create mini test suites, given the protocol and git implementation. This made the Gingko version clearer, arguably, but it can be reduced away here for a bit less nesting. Signed-off-by: Michael Bridgen <michael@weave.works>
This tidies the random string testWithRepoAndImagePolicy() arguments into a struct, which reduces clutter (and the chance of getting them in the wrong order) in invocations. Signed-off-by: Michael Bridgen <michael@weave.works>
darkowlzz
approved these changes
Nov 11, 2021
Owner
darkowlzz
left a comment
darkowlzz
left a comment
There was a problem hiding this comment.
Thanks. Looks so much better now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A couple of readability improvements that don't add too many LoC. Readability is subjective, of course -- use what you want :-)