改善模糊搜索逻辑，以及一些小的 Bug 修复和小功能的添加 #862

tonyfettes · 2020-08-23T16:17:00Z

#858 引入的模糊搜索的逻辑有点问题，本 PR 修改后模糊搜索的行为表现为

不允许嵌套模糊搜索。
按 p 时会跳转到到被搜索歌单对应的歌曲处，而不是最近一次的搜索结果。

本 PR 还修复了一些小的 Bug，添加了一些小的 Feature。

修复的 Bug :

20 分钟后需要更新歌曲 url 时候会弹出两条一模一样的消息。
配置文件中 page_length 的选项指定的行为（每页条目数）会被忽略，导致程序始终表现为根据终端尺寸自适应调节的行为
增加当前列表模糊搜索，修复连续跳转Bug #858 中重写歌词更新的逻辑后，出现的歌词时间顺序错位的现象
修正滚动字符串的滚动速度（原来是非 ASCII 一次滚 3 个，ASCII 一次滚一个，现在是非 ASCII 一次滚 1 个，ASCII 一次滚两个）
pip 依赖没有即时更新的问题 archlinux kde 和 i3 下的问题 #861
按 - 程序崩溃
切歌耗时会逐渐变长
20 min 歌曲刷新 url 后播放/暂停状态会显示错误

添加的功能:

可在配置文件中自定义的左右对齐的宽度
根据终端尺寸自动调整长度的进度条

改变的应用程序行为:

评论区添加光标所在处的评论显示
在非单曲循环的情况下遇到版权问题自动播放下一首，而不是目前的停止播放

是 Bug 但是目前不打算修:

（不合理的行为）切换到版权问题歌曲时进度条和歌词显示位置不为开头。（不修的原因：对于无法播放的歌曲播放的信息是没有意义的，目前这个问题可能既不紧急也不重要）

program will abort.

2. A possible fix to a possible bug: when fetch the version info sometimes one of latest and version will be 'int' 3. self.margin -> self.left_margin_ratio

…frese -> refresh (typo).

1. Add right margin to menu and playinfo 2. adjust scrolling speed of the string

1. Fix the bug that behavior set by "page_length" will be override as auto adjusted. 2. make the comment section with right margin.

Sync with upstream

1. Set the classifier natural language in setup.py from English to Chinese (Simplified). 2. Use <kbd> label to wrap the shortcut key in README.md 3. Add description to num + key 4. Add bug report for fuzzy search

1. Set the classifier natural language in setup.py from English to Chinese (Simplified). 2. Use <kbd> label to warp the shortcut key in README.md. 3. Add description to num + key. 4. Add bug report for fuzzy search.

search result. Corresponding to bug 3 in #10.

Now the wrapped fuzzy search is disabled.

1. Remove problem & solution 858. 2. Make number key instructions more clear. 3. The path of log file should now obey XDG standard.

…call space_key_event()

…lume() will abort the application.

status in playinfo will be wrong.

wangjianyuan10 and others added 30 commits March 11, 2020 03:03

mac专用版本1.0

e59e25a

mac专用版本1.0

799150c

1.0安装

e44bd9f

修复首次进评论的bug,提高主循环效率

342420c

修复快速按下一首多个子进程bug

a829e67

修复线程混乱问题增加数字跳转快捷键

6494f2b

修复线程混乱问题增加数字跳转快捷键

e154b2e

修复线程混乱问题增加数字跳转快捷键

6a7018c

修复线程混乱问题增加数字跳转快捷键

836aa83

修复线程混乱问题增加数字跳转快捷键

0de73f1

修复线程混乱问题增加数字跳转快捷键

483d391

修复线程混乱问题增加数字跳转快捷键

842e8a8

修复线程混乱问题增加数字跳转快捷键

f68f927

修复线程混乱问题增加数字跳转快捷键

db7911e

修复线程混乱问题增加数字跳转快捷键

097b31d

修复线程混乱问题增加数字跳转快捷键

773b39c

增加显示颜色自定义，按键映射，使用定时器实现自动关闭功能；修复搜索按键功能映射错误；发现快速切换时会播放多首音乐

a7e0ee6

0.1

90c7f6d

0.1

58ebaa1

0.2

ef4807a

0.2

7ebeac4

0.2

f182053

Fix comments bug.

c473439

Fix comments bug.

5c97a93

Fix comments bug.

f1a4017

Fix comments bug.

6f1b097

Optimize align of comments.

c1b69c3

Optimize align of comments.

0513f48

Optimize align of comments.

aeb82fb

Optimize for someone who write ':' in their comments.

2397a66

tonyfettes added 22 commits August 18, 2020 16:37

Use black to format code.

f011c7d

Merge #653.

7cf275d

Fix the bug that if the keymap are not defined in user's json, the

914361a

program will abort.

Update config file when exit to keep the config file up to dated.

e5bfba6

1. Add notification for the case when url NoneType

e8b0900

2. A possible fix to a possible bug: when fetch the version info sometimes one of latest and version will be 'int' 3. self.margin -> self.left_margin_ratio

Fix double notification after 20 minutes (when urls are updated) & re…

e8f11c9

…frese -> refresh (typo).

Margin related feature & bug fix.

a21ce5f

1. Add right margin to menu and playinfo 2. adjust scrolling speed of the string

Important bug fix

76f8250

1. Fix the bug that behavior set by "page_length" will be override as auto adjusted. 2. make the comment section with right margin.

Add process bar with scalable size.

383c8cd

Refracte update_margin(), format code.

f542660

Update dependencies.

7e71e37

Merge remote-tracking branch 'upstream/master' into wjy_kwph

561f3b4

Sync with upstream

Merge master to pr branch.

bdf76ca

Update README.md

9d4839c

1. Set the classifier natural language in setup.py from English to Chinese (Simplified). 2. Use <kbd> label to wrap the shortcut key in README.md 3. Add description to num + key 4. Add bug report for fuzzy search

Update README.md and setup.py

fcd1388

1. Set the classifier natural language in setup.py from English to Chinese (Simplified). 2. Use <kbd> label to warp the shortcut key in README.md. 3. Add description to num + key. 4. Add bug report for fuzzy search.

Fix lyrics logic bug & black format.

be5df86

[Bug Fix] Now press 'p' will go to the entry in search target, not

df8e021

search result. Corresponding to bug 3 in #10.

[Bug Fix] Fuzzy search bug 1 in #10

b0befb1

Now the wrapped fuzzy search is disabled.

[Bug Fix] #10

e4996fb

Fix mistake in setup.py

c2c92d0

Merge master to pr branch.

2fd0c93

Update README.md

25ecce8

1. Remove problem & solution 858. 2. Make number key instructions more clear. 3. The path of log file should now obey XDG standard.

kigawas self-requested a review August 24, 2020 04:23

tonyfettes added 4 commits August 25, 2020 15:20

[Bug fix] No lyrics in Chinese songs.

976e335

[Bug fix] Remove unneccessary code to reduce increasing latency when …

f9c000b

…call space_key_event()

[Bug fix] Fix the bug that when no song is being played, call tune_vo…

5f31bba

…lume() will abort the application.

[Bug Fix] Fix the bug that sometimes (when refresh urls) the play/pause

f8fb086

status in playinfo will be wrong.

tonyfettes marked this pull request as ready for review August 25, 2020 15:15

Use black to format code.

506371b

kigawas merged commit d0f6ddf into darknessomi:master Aug 26, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

改善模糊搜索逻辑，以及一些小的 Bug 修复和小功能的添加 #862

改善模糊搜索逻辑，以及一些小的 Bug 修复和小功能的添加 #862

tonyfettes commented Aug 23, 2020 •

edited

Loading

改善模糊搜索逻辑，以及一些小的 Bug 修复和小功能的添加 #862

改善模糊搜索逻辑，以及一些小的 Bug 修复和小功能的添加 #862

Conversation

tonyfettes commented Aug 23, 2020 • edited Loading

tonyfettes commented Aug 23, 2020 •

edited

Loading