Fixed CharacteristicLongWriteOperation defaults #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Android 13 when negotiated MTU > 515, CharacteristicLongWriteOperation would by default split data into chunks that did not fit Android internal data buffer for BLE writes. Reason for that is that on Android 13 the maximum attribute data buffer length was reduced from 600 to 512 bytes - which is now according to BLE Specs. Android 14 makes MTU negotiation to the maximum supported value on Android (517) by default, making this problem more likely to surface.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Android 13 when negotiated MTU > 515, CharacteristicLongWriteOperation would by default split data into chunks that did not fit Android internal data buffer for BLE writes. Reason for that is that on Android 13 the maximum attribute data buffer length was reduced from 600 to 512 bytes - which is now according to BLE Specs. Android 14 makes MTU negotiation to the maximum supported value on Android (517) by default, making this problem more likely to surface.
Fixes #843