-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed robolectric and electricspock dependency #770
Removed robolectric and electricspock dependency #770
Conversation
# Conflicts: # mockrxandroidble/build.gradle # rxandroidble/build.gradle # sample-kotlin/build.gradle # sample/build.gradle
Agh, missed the test in the sample. Will fix later. |
This PR is now complete |
Seems to work without now, and errors with
This looks amazing! 🚀 In the long run I want to put most of Android specific APIs behind a library-only accessor that would be dead simple and test only the library logic. |
Sounds good. This may help in that process. Some of the classes have only the methods used stubbed. But for now, this enables the transition to gradle 7 and allows us to upgrade groovy, junit and spock. |
I finally got a moment to test properly. I have difficulties in running |
@dariuszseweryn this should work now with my latest commit. Not sure if this is the ideal way to achieve it but it works! |
# Conflicts: # dependencies.gradle # gradle/gradle-mvn-push.gradle
@dariuszseweryn This branch now contains #763 and passes |
I decided to fork this project so we can maintain it more actively and merge the PRs we had open. I've forked at https://github.com/NRB-Tech/RxAndroidBle/ and it's on Maven Central as io.nrbtech.rxandroidble. I've merged this PR there. |
Hi @nrbrook |
Resolves #769
This PR replaces Robolectric with handcrafted stubs. It also updates groovy and spock. All tests pass.