Fixes crash due to Receiver not registered
#430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…registered` when it is immediately unsubscribed before it even started listening
|
|
|
@bleeding182 I wonder if it could be possible to catch this use-case with a test... Have you checked perhaps? |
|
@DariuszAniszewski No, I did not look into writing any tests The exception seems to be thrown when downstream is already disposed, hence it would immediately call unregister before we even registered. By moving the unregister callback to the end this can't happen since we will always have registered by then |
uKL
approved these changes
May 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would happen on a 6P when toggling bluetooth on and off. This will make sure that we do always register before we unregister.