Fix deadlock reported by #426 when FIFORunnable is disposed before running #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…osed before running
|
|
|
@bleeding182 Did you confirmed that this change indeed helps? |
|
@DariuszAniszewski Hey there! Yes, been debugging today, can't reproduce it with this fix. |
|
It's @dariuszseweryn ;) Great to hear that. I think that we should add a test for The test should be straightforward to write and just verify that the P.S. Maybe it would be a bit clearer if the code be something like: |
uKL
approved these changes
May 24, 2018
| @@ -35,44 +35,46 @@ public int compareTo(@NonNull FIFORunnableEntry other) { | |||
| } | |||
|
|
|||
| public void run(QueueSemaphore semaphore, Scheduler subscribeScheduler) { | |||
|
|
|||
| if (operationResultObserver.isDisposed()) { | |||
| RxBleLog.d("Operation was about to be run but the observer was already disposed: " + operation); | |||
There was a problem hiding this comment.
How about?
The operation was about to be run but the observer had been already disposed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported we should release the semaphore when we don't execute the operation.
Fixes #426